search

uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.12k stars 767 forks source link

blogto.com: breakage #23709

Closed h2559 closed 5 months ago

h2559 commented 5 months ago

Prerequisites

I tried to reproduce the issue when...

Description

so i go to this website called blogTO, and one of the default filters (when I reset the extension) disables instagram enbeds,

one of the ways to get around this is to disable (edit: one of the ads list, either ublock filter ads, or easylist, i forget which exactly), which is bad because a lot of other ads gets passed thru, and then i read that someone said you can just add instagram to the trusted sites so that the entire website gets whitelisted! it all works now, but there is a strange bug...

A specific URL where the issue occurs.

https://www.blogto.com/eat_drink/2024/05/cafe-olimpico-montreal-coming-toronto/

Steps to Reproduce

  1. reset ublock origin to defaults (optional, but lets work with a clean slate)
  2. go to trusted sites and add instagram.com
  3. go to blogto.com, click on an article until you see an instagram enbed, it should be blank
  4. refresh the webpage, the embed should show up now!

Expected behavior

at step 3, step 4 should happen instead, without refreshing a second time

i took some screenshots: https://github.com/uBlockOrigin/uBlock-issues/assets/20052727/d0537112-7017-455f-95ff-4cde3f3bafb2

https://github.com/uBlockOrigin/uBlock-issues/assets/20052727/01789ebc-38dd-49a5-b282-d7b6ad486d3e

https://github.com/uBlockOrigin/uBlock-issues/assets/20052727/15ae4e53-8afa-4c3a-8d97-5bd840090aa3

https://github.com/uBlockOrigin/uBlock-issues/assets/20052727/354b3d4d-817d-4da5-ab16-bfb04b8ded91

Actual behavior

step 4 happens

i don't know why this happens, but i am guessing the filter lists logic doesnt activate the trusted list section the first time, it needs a refresh?

uBO version

1.57.0

Browser name and version

Version 124.0.6367.201

Operating System and version

mac os x big sur 11.7.10

krystian3w commented 5 months ago

If you claim it's a filter error, you're breaking the reporting rules:

  • [x] I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.

If this is a change in the filter processing logic, it would be good to indicate what version of uBo started working incorrectly, e.g. 1.56+. Then reporting in this repository (uBlockOrigin/uBlock-issues) makes sense if it is worth improving the new logic.

There is no point in adding Instagram to your trusted ones when it comes to frames (unless you know how to do it from the rules tab à la firewall).

garry-ut99 commented 5 months ago

I could reproduce the blank embed instagram only the first time I visited: https://www.blogto.com/eat_drink/2024/05/le-lert-toronto/ (on Firefox) but not anymore, despite I tried many times, on both Firefox and Chromium, even with cache & cookies cleared and hard reload, even with different articles, hence I'm unable to determine whether it was caused by filters or not, because I can no longer reproduce.

krystian3w commented 5 months ago

Sometimes they don't load for me in the 'Virtualna Poland' area, and less often in the Polsat-Interia group.

stephenhawk8054 commented 5 months ago

I also could only reproduce the first time visit the site yesterday. After that I could not reproduce it any more.

garry-ut99 commented 5 months ago

Has happened again today for me: blank at the first visit only (in Firefox), then I have tried to reproduce in Chromium immediately afterwards: I did reproduce but only after several page reloads (means: not at the first visit). Nothing blocking instagram in the logger, except the beacon which appears blocked even when the instagram embed does load, so there doesn't seem to be any relationship.

Next time I will try to visit the page and reproduce the breakage with uBlock disabled to make sure whether it's caused by filters or not.

garry-ut99 commented 5 months ago

Ok, after several page realoads I have reproduced again the blank embed instagram in Chromium with uBlock disabled.

h2559 commented 5 months ago

ok, so does that mean it is not ublock origins fault? i could have never imagined someone could impliment instagram wrong on their website, especially on a site as popular as blogTO, they must have a bunch of amateurs coding the site.

stephenhawk8054 commented 5 months ago

@h2559 Currently can you reproduce the issue any more?

h2559 commented 5 months ago

@h2559 Currently can you reproduce the issue any more?

I am trying to find a new instagram embed on blogto but the recent new posts don't have them, so i haven't been able to test. i would imagine nothing has changed, it is not like the coders on that site are reading the thread here.

gorhill commented 5 months ago

I have reproduced again the blank embed instagram in Chromium with uBlock disabled.

Closing as an external issue, unrelated to uBO.

h2559 commented 4 months ago

ok, i visitied https://www.blogto.com/eat_drink/2024/05/brkfree-mississauga/ with my chrome browser that has uBO enabled, insta embed is blocked.

then i used a virgin safari browser (because it sucks) with no ad blockers installed and the insta embed showed up!

then i went back to chrome and the insta embed showed up (this would be the 2nd visit, so it is expected that it would show up, as mentioned above)

stephenhawk8054 commented 4 months ago

The problem is the embed can be not-appear at random even without uBO.

h2559 commented 4 months ago

The problem is the embed can be not-appear at random even without uBO.

in your previous post you asked me if i can rerepro the issue, at first i couldn't because i couldn't find a new insta embed on the blogto site, today they posted a new article that had an insta embed, so i was able to try again, and i posted the results

stephenhawk8054 commented 4 months ago

Yes, I was asking to see if you still had the issue with your link above because at that time, there's only our speculations.

Anyways, the only way to investigate this issue is having clear steps to reproduce. Otherwise, we can't do much.

h2559 commented 4 months ago

i hope someone else can give it a try then, the new link is in the post i made today, hopefully something can come out of it, i t is prolly one of the default filter lists being too agressive? or maybe the logic is not whitelisting the trusted site list the first time with out a refresh, just some ideas

stephenhawk8054 commented 4 months ago

As said, the issue can be from the website itself, as others were able to reproduce even without uBO.