uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
3.79k stars 728 forks source link

metric.sonix.network: breakage #24351

Closed bluecmd closed 2 days ago

bluecmd commented 2 days ago

Prerequisites

URL address of the web page

https://metric.sonix.network/grafana/d/jKdZekQ4z/overview?orgId=1&refresh=1m

Category

breakage

Description

As per https://github.com/easylist/easylist/issues/19380 this is an EasyList false positive, but the EasyList community seems unwilling to fix this.

This breaks self-hosted Grafana instances.

Other extensions used

none

Screenshot(s)

Screenshot(s) ![image](https://github.com/uBlockOrigin/uAssets/assets/149442/82c835f2-0e09-4f61-b5dc-887bb91f5334)

Configuration

```yaml uBlock Origin: 1.58.0 Firefox: 127 filterset (summary): network: 136925 cosmetic: 46993 scriptlet: 20123 html: 1851 listset (total-discarded, last-updated): default: user-filters: 0-0, never ublock-filters: 39076-113, now ublock-badware: 8664-0, now ublock-privacy: 1018-4, now ublock-unbreak: 2425-2, now ublock-quick-fixes: 117-5, now easylist: 86376-174, now easyprivacy: 51129-65, now urlhaus-1: 15055-5, now plowe-0: 3543-988, now filterset (user): [empty] trustedset: added: [array of 34 redacted] userSettings: [none] hiddenSettings: [none] supportStats: allReadyAfter: 1110 ms maxAssetCacheWait: 217 ms cacheBackend: indexedDB popupPanel: blocked: 1 network: sonix.network: 1 ```
stephenhawk8054 commented 2 days ago

What is broken here? The site looks normal for me

image

bluecmd commented 2 days ago

I've installed a specific Grafana version on the site to a version that doesn't have the error message. The API call still happens however, so you should still see the block in uBO.

SeamlessRelaxation commented 2 days ago

And apart of an error message, was there anything actually broken on the user's side? https://github.com/easylist/easylist/issues/19380#issuecomment-2181065677

bluecmd commented 2 days ago

No, the error message was just a visual issue.

stephenhawk8054 commented 2 days ago

No, the error message was just a visual issue.

Then we can't address it as breakage for clients / users. The most we can do is hiding the error message site by site as annoyance issue.

bluecmd commented 2 days ago

Ah, I see. That makes sense! Do you require anything from me to add such hiding? As far as I understand the error dialog is generic so getting just this particular error hidden might be hard.

stephenhawk8054 commented 2 days ago

Currently I don't know how to reproduce it. Can you right click on the error message, open the inspect elements of it and screenshot to here?

bluecmd commented 2 days ago

Sure, here is the popup on a non-patched Grafana instance I have access to:

image

stephenhawk8054 commented 2 days ago

Can you test this filter?

metric.sonix.network##+js(no-fetch-if, /frontend-metrics)

Click on uBO icon > ⚙ Dashboard button > Add the filter(s) in "My filters" pane > ✓ Apply changes > Open new tab and test again.

bluecmd commented 2 days ago

Yes! That seems to work wonderfully. I don't see any request for the metrics site, which I assume is what the no-fetch-if is for - but Grafana doesn't seem to care. I think this is a great solution, removing the metrics callback for folks and not breaking the UI.

If you want to add it per domain I would like to request it being added to metric.sonix.network as well as grafana.local.sonix.network - or even better **.sonix.network if such a thing is possible.