uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.2k stars 776 forks source link

aliprice.com: nuisance #25228

Closed 3xploiton3 closed 2 months ago

3xploiton3 commented 2 months ago

image image

Complete mode

https://www.aliprice.com/

garry-ut99 commented 2 months ago

aliprice.com

Is that an exact link where the popup appears or you provided us only a link to main page and you want us to blind-guess which is the exact link the issue occurs on. I can't reproduce the popup on main page, and even after trying some other links, subpages, items etc. If the popup appears not on main page, but only on some specific subpages/links, provide the exact example link.

Also provide information whether the popup appears as Guest or after Logging in, or in both cases, I tried only as Guest.

3xploiton3 commented 2 months ago

tried with account login

garry-ut99 commented 2 months ago

Ok, I've tried now when Logged-in and can reproduce, but the popup appears on both uBOL and uBO, which means it's not something specific to uBOL, hence should be moved to uAssets / EasyList repository.

These example filters will work: aliprice.com###share-modal, .show.fade.modal-backdrop aliprice.com##body:style(overflow: auto !important;)

aliprice.com###share-modal can be even made generic ###share-modal as similiar exists in EasyList – Social Widgets : ###share-modal-link (https://github.com/easylist/easylist/blob/edd4099e29df46c491e6ee5a7d31166b0803144a/fanboy-addon/fanboy_social_general_hide.txt#L1148).

krystian3w commented 2 months ago

First you should check how many pop-ups didn't block scrolling by position: absolute or overflow: hidden to rare repair scrolling or fade under pop-up.

ABP CSS injection wants to do incompatible syntax with uBo and AdGuard:

! ABP idea to inject CSS in future (skipped $)
aliprice.com##body { overflow: auto !important; }

and maybe limit it for lists outside the Eyeo server.

These syntax works for remove elements in ABP panel 4.5+ (skipped $ so won't run with newest uBo or AdGuard):

abptestpages.org###remove-id {remove: true;}
garry-ut99 commented 2 months ago

Small reminder: as per https://github.com/uBlockOrigin/uAssets/issues/25228#issuecomment-2334016866, the report hangs here unnecessarily and isn't being fixed, it should be transferred to uAssets and fixed there, as it affects both uBO & uBOL.

MasterKia commented 2 months ago

Reproduced using uBO.

aliprice.com###share-modal, .show.fade.modal-backdrop
aliprice.com##body:style(overflow: auto !important;)

@ryanbr Needs an account.

tried with account login

@3xploiton3 Please share all the details like this in the first post, use a translator if you don't know English. You have made many invalid issues before: https://github.com/uBlockOrigin/uAssets/issues?q=is%3Aissue+author%3A3xploiton3+is%3Aclosed+label%3Ainvalid

krystian3w commented 2 months ago

I would advise to watch if global slicing will be added by:

###share-modal without list of domains with unlocked scroll and disabled fog.