search

uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.15k stars 773 forks source link

Gamepedia Instart block breaks wikis #4767

Closed assignUser closed 5 years ago

assignUser commented 5 years ago

URL(s) where the issue occurs

https://pathofexile.gamepedia.com/The_Wretched

Describe the issue

The Instart block gamepedia.com##+js(abort-current-inline-script.js, RegExp, Instart) discussed in #2468 now seems to break the gamepedia wikis by blocking resource loading.

Screenshot(s)

image

Versions

Notes

deactivating uBlock filter fixes this.

okiehsch commented 5 years ago

I can't reproduce image

mapx- commented 5 years ago

However, I get Instart only as comment in the page source, otherwise instart or INSTART (and I cannot reproduce the issue)

mapx- commented 5 years ago

no breakage in FF too, even using gamepedia.com##^script:has-text(/i10C/i)

okiehsch commented 5 years ago

OK, I found the reason for the breakage, using Chrome if I disable uBO-extra the site breaks because of the g00 redirection.

okiehsch commented 5 years ago

I guess we can remove the filter, it does not work anymore anyway.

mapx- commented 5 years ago

adding gamepedia.com##+js(set-constant.js, JSON.parse, noopFunc) or gamepedia.com##+js(set-constant.js, String.prototype.charAt, noopFunc)

seems to reduce the number of g00 requests

mapx- commented 5 years ago

no ... still breakage

okiehsch commented 5 years ago

gamepedia has thousands of wikis, I won't add such kind of filters for it, the best fix is to use uBO-extra.

I get g00 requests using Firefox, can you reproduce?

mapx- commented 5 years ago

yeah, so needing i10c filter

okiehsch commented 5 years ago

Yes. gamepedia.com##+js(abort-current-inline-script.js, setTimeout, g00) works on my end with Firefox, but not with Chrome suggesting a race condition, so we might as well use a Firefox specific filter.

Hrxn commented 5 years ago

gamepedia has thousands of wikis, I won't add such kind of filters for it, [..]

Well, yes, but they should all work the same, a generic filter wouldn't be possible?

okiehsch commented 5 years ago

Well, yes, but they should all work the same, a generic filter wouldn't be possible?

gamepedia.com##+js(set-constant.js, JSON.parse, noopFunc)
gamepedia.com##+js(set-constant.js, String.prototype.charAt, noopFunc)

I still get redirected with those filters and they have the potential to break site functionality. Maybe they don't I have not checked.