uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.07k stars 761 forks source link

ndtv.com{Ads} #5190

Closed ghajini closed 5 years ago

ghajini commented 5 years ago

URL(s) where the issue occurs

1. https://khabar.ndtv.com/news/bollywood/total-dhamaal-box-office-collection-day-27-ajay-devgn-anil-kapoor-madhuri-dixit-blockbuster-record-2010671?pfrom=home-topstories

  1. try news at these ndtv.com sports.ndtv.com gadgets.ndtv.com food.ndtv.com swirlster.ndtv.com

Describe the issue

1. what went wrong currently(with default settings) block of taboola.com hides some legit news stories at bottom of page

2 how the page should be there should be no hide of legit content provided by taboola....also there should be blockage of sponsored ads by taboola

  1. what steps you have done in order to solve problem also in order to unbreak news content at bottom of page if i allow taboola.com it brings back sponsored ads as well alongwith unblocking news content

Screenshot(s)

1.

how the page looks with default settings https://user-images.githubusercontent.com/20338483/54755250-76882400-4bdd-11e9-9855-5736288dfc7f.jpg

2. You need to allow taboola in order to see news content at bottom of page but this invites sponsored.ads as well https://user-images.githubusercontent.com/20338483/54755360-b64f0b80-4bdd-11e9-81e0-629bfb65e672.png

Versions

Settings

issue you can reproduce on mobile device only i.e. firefox android

@Alex-302 adguard browser extension for firefox android also suffers from this breakage @jspenguin2017 @okiehsch

gwarser commented 5 years ago

@mapx- with your exceptions, on html version ads are not hidden, looks like this: https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478221604

I'm not convinced these "Deepika"-like thumbnails are not ads, because they seems to link to random external domains and after click they redirect through the same tracker as ads.

mapx- commented 5 years ago

@gwarser did you enable AdGuard Mobile Ads filter too ?

Even in html version I get no such ads, weird

gwarser commented 5 years ago

Sorry - it's other way around, AMP ads are not hidden. It's because I also have "Ignore generic cosmetic filters" checked (mobile default).

mapx- commented 5 years ago

last filters (still not getting those ads)

@@||cdn.ampproject.org/*amp-ad$script,domain=ndtv.com
@@||cdn.taboola.com/libtrc/ndtv-ndtvmobile/loader.js$script,domain=ampproject.net
@@||cdn.taboola.com/libtrc/impl.$script,domain=ampproject.net
@@||trc.taboola.com/ndtv-ndtvmobile/$script,domain=ampproject.net
ndtv.com#@#amp-embed[type="taboola"]
ndtv.com##[id^="adslot"]
ndtv.com##div[style]:has-text(/advertisement/i)
mapx- commented 5 years ago

However, without them the page is broken

gwarser commented 5 years ago

These unhidden ads are from iframe from https://d-984640819716406753.ampproject.net/1903262220080/frame.html

kulfoon commented 5 years ago

This https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478328943 fixed my issue https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478326826

gwarser commented 5 years ago

Any of these hides them:

ampproject.net##.trc-content-sponsored
ampproject.net##.trc_rbox .syndicatedItem
ampproject.net##.trc_rbox_border_elm .syndicatedItem
ampproject.net##.trc_rbox_div .syndicatedItem

They are generics from EasyList.

mapx- commented 5 years ago

@ghajini , test again after updating your lists

ghajini commented 5 years ago

@gwarser with due respect, May I know which URL you get https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478296564 I asked you this already previously so that I can understand your comment https://github.com/uBlockOrigin/uAssets/issues/5190#issuecomment-478327909...... in better way

gwarser commented 5 years ago

Heh, sorry, this was random page and I cannot find it in history now.

These thumbnails now link to hop.live/video

ghajini commented 5 years ago

@mapx thanks..... @gwarser Yeah sometimes ad of deepika(actress here😅) may be there as well as might be content..... Im also at thought of requiring minimum exception filters, you may suggest filters or equivalent defuser

mapx- commented 5 years ago

yeah, we know Deepika (- Novak story) ;)

ghajini commented 5 years ago

Breakage-

Article content is hidden... URL- https://www.ndtv.com/india-news/watch-how-india-blasted-satellite-300-km-above-earth-with-mission-shakti-2019335?pfrom=home-topscroll

setup -

Firefox android browser 66

Ublock origin 1.18.16

Screenshots-

  1. Ublock origin enabled

https://user-images.githubusercontent.com/20338483/55687638-cd705600-595e-11e9-9134-090724e6485b.jpg

  1. Ublock origin disabled-

https://user-images.githubusercontent.com/20338483/55687663-11fbf180-595f-11e9-89ad-f097b2a37ed3.jpg

Notes- Breakage not on desktop browsers

mapx- commented 5 years ago

tested 3 user agent:

ghajini commented 5 years ago

User agent changer not useful, try https://github.com/uBlockOrigin/uAssets/issues/3482#issuecomment-433596075 if you can

mapx- commented 5 years ago

same result (and using indian ip via hola) => I get the whole article

gwarser commented 5 years ago
www.ndtv.com#@#div[style]:has-text(/advertisement/i)

image

mapx- commented 5 years ago

I can replace that filter by ndtv.com##:xpath(//div[contains(text(),"Advert")])

@gwarser , does it work for you ?

gwarser commented 5 years ago

Looks good.

ghajini commented 5 years ago

Yes that unblocked articles..... @gwarser since it looks like you are closer to android setup, any filter needed or deducted in order to have minimum exception filters for site

gwarser commented 5 years ago

What you mean?

ghajini commented 5 years ago

Firefox android Ublock origin 1.19.6

@mapx- Does something changed in filters....

https://www.ndtv.com/india-news/veteran-film-and-theatre-personality-girish-karnad-dies-at-81-2050674?pfrom=home-topscroll

legit articles at bottom of page are inaccessible....

mapx- commented 5 years ago

scrolling and scrolling here ... no apparent issue, screenshot with what's missing on your side ?

ghajini commented 5 years ago

1. Go here https://www.ndtv.com/india-news/veteran-film-and-theatre-personality-girish-karnad-dies-at-81-2050674?pfrom=home-topscroll

2. Wait for bottom articles to fetch ..scroll below

  1. Click on them(bottom articles)
  2. Result =they don't load on my side,they are blocked by adguards mobile ads filter ||trc.taboola.com^ as per logger Also blocking window is not displayed by ublock origin 1.19.6 firefox android
mapx- commented 5 years ago

does this work for you ? @@||trc.taboola.com/ndtv*/log/*$domain=trc.taboola.com

ghajini commented 5 years ago

Perfect 👍

ghost commented 4 years ago

hello what about this for hide the promoted links:

ndtv.com##+js(aopr, _taboola)

https://gadgets.ndtv.com/games/features/age-of-empires-2-definitive-edition-release-date-download-cheats-gameplay-civilizations-steam-releas-2130894

mapx- commented 4 years ago

Those promoted links are self promo, pointing to the same site articles, right ?

you can add gadgets.ndtv.com##.trc_rbox_container

ghajini commented 4 years ago

https://www.ndtv.com/india-news/wasnt-the-one-in-a-mask-aishe-ghosh-hits-back-at-delhi-police-claims-2162086?pfrom=home-topscroll

@mapx- Once again some filter from adguard mobile filters blocked articles at bottom of page

https://user-images.githubusercontent.com/20338483/72173610-fc3fbf00-33fd-11ea-94f3-be159be7878f.jpg

On clicking on them page go blank like this https://user-images.githubusercontent.com/20338483/72173663-14afd980-33fe-11ea-880a-b0870a1b0b33.jpg

ghajini commented 4 years ago

This time @@||trc.taboola.com/ndtv-ndtvmobile/log/3/click$subdocument,domain=www.ndtv.com Unblock articles for me

ghajini commented 3 years ago

Promoted 3rd party (ads)

https://food.ndtv.com/health/morning-coffee-may-not-be-a-great-option-for-the-diabetics-experts-explain-why-2305986

Platform =

Firefox android stable ,ublock origin 1.30

screenshots=

https://user-images.githubusercontent.com/20338483/95286700-aa8b6e80-0881-11eb-8ad0-155958cffb3f.jpg

https://user-images.githubusercontent.com/20338483/95286736-c1ca5c00-0881-11eb-9dbf-28026a684007.jpg

ghajini commented 3 years ago

Amazon promotions ads

https://gadgets.ndtv.com/telecom/news/jio-5g-service-launch-india-rollout-second-half-2021-mukesh-ambani-2335646?pfrom=topstory

Screenshot_2020-12-08-15-38-45-358_org mozilla fenix

Firefox android, ubo stable

mapx- commented 3 years ago

test

gadgets.ndtv.com###header_ad_before_id
gadgets.ndtv.com##.__wdgt_rhs_kpc
gadgets.ndtv.com##._kpw_wrp_rhs_widget
ghajini commented 3 years ago

Missed Screenshot_2020-12-08-16-07-12-819_org mozilla fenix

mapx- commented 3 years ago

what about (remove the filters above):

||hotdeals360.com^$3p

ghajini commented 3 years ago

what about (remove the filters above):

||hotdeals360.com^$3p

Correct ,work

ghajini commented 2 years ago

firefox android bottom articles are again hidden here

mapx- commented 2 years ago

link ?

ghajini commented 2 years ago

link=

https://www.ndtv.com/india-news/no-bail-for-aryan-khan-today-arguments-to-continue-in-bombay-high-court-tomorrow-2588600#pfrom=home-ndtv_topscroll

mapx- commented 2 years ago

could you post a screenshot indicating those bottom articles ?

ghajini commented 2 years ago

https://user-images.githubusercontent.com/20338483/138917038-8f7206ef-c7e0-45f3-abf1-948f9b7dd853.png

the one marked are legit and other named sponsored are ads

mapx- commented 2 years ago

test

ndtv.com#@##taboola-below-article-thumbnails
ndtv.com##.tbl-feed-card:has(.trc-content-sponsored)
@@||trc.taboola.com/ndtv*/trc/*/json$xhr,domain=ndtv.com
ghajini commented 2 years ago

do not work, i don't see stories loaded at end of original article

mapx- commented 2 years ago

see above, test again, missing to add a filter

ghajini commented 2 years ago

not working again...' same old story, someone blocks taboola (aka adguard mobile ads filters,ubo privacy etc)

allowing taboola works

mapx- commented 2 years ago

working fine on desktop

ghajini commented 2 years ago

you have real android,pls test

mapx- commented 2 years ago

well, for mobile add

@@||trc.taboola.com/ndtv-ndtvmobile/trc/$xhr,domain=ndtv.com

too

mapx- commented 2 years ago

modified the filters above, for desktop / mobile needing:

@@||trc.taboola.com/ndtv*/trc/*/json$xhr,domain=ndtv.com