uBlockOrigin / uAssets

Resources for uBlock Origin, uMatrix: static filter lists, ready-to-use rulesets, etc.
GNU General Public License v3.0
4.24k stars 779 forks source link

Breaks starfiles.co #9047

Closed QuixThe2nd closed 3 years ago

QuixThe2nd commented 3 years ago

Prerequisites

URL(s) where the issue occurs

https://starfiles.co https://starfiles.ml

Describe the issue

The main JS file: https://cdn.jsdelivr.net/combine/gh/QuixThe2nd/Starfiles-JSDelivr@24/js/functions.min.js,gh/QuixThe2nd/Starfiles-JSDelivr@24/js/head.min.js,gh/QuixThe2nd/Starfiles-JSDelivr@24/js/analytics.min.js,npm/crypto-js@4/crypto-js.min.js,npm/intro.js@3/intro.min.js,npm/@popperjs/core@2.0/dist/umd/popper.js?e9c654833f2a1e543a11dac9dc751bf8d6523b601cf48d97d71de7a01ef5adb8fdef0ac70ce21b2559ef0e88fb32d011 as of writing this does not load, which breaks many essential functions. An example of this is the getScript function is never declared.

### Screenshot(s) ![image](https://user-images.githubusercontent.com/25378634/117536514-b53bfb00-b03e-11eb-9a9d-8ed7ac5c8094.png) ![image](https://user-images.githubusercontent.com/25378634/117536525-cab12500-b03e-11eb-89cc-e1cfc1dc66aa.png)

Versions

Settings

No changes

Notes

Listed above

QuixThe2nd commented 3 years ago

That link changes frequently, I just sent it to explain what was happening

uBlock-user commented 3 years ago

That link changes frequently

Changes how ? Give an example.

QuixThe2nd commented 3 years ago

As its a JSDelivr link, the files included change and the version numbers change. Right now its @24 for some, in the future that will be different. Also more files are added to it by adding something like ,gh/user/repo@version/file_path to the end. Hope that explains it.

QuixThe2nd commented 3 years ago

Thanks! It might be best to change it from: @@||cdn.jsdelivr.net^*/js/analytics.min.js$script,domain=starfiles.co|starfiles.ml To: @@||cdn.jsdelivr.net^*.js$script,domain=starfiles.co|starfiles.ml as /js/analytics.min.js could get changed.

uBlock-user commented 3 years ago

as /js/analytics.min.js could get changed.

I disagree, you're the one in charge of the site, so don't change it or don't use baits from EasyPrivacy.

QuixThe2nd commented 3 years ago

Yeah, I get what you're saying. Thanks for the help, I really appreciate it.

Aerosane commented 3 years ago

Ublock once again breaks the website. I just checked and the new URL is: https://cdn.jsdelivr.net/combine/gh/QuixThe2nd/Starfiles-JSDelivr@238/js/functions.min.js,gh/QuixThe2nd/Starfiles-JSDelivr@238/js/head.min.js,gh/QuixThe2nd/Starfiles-JSDelivr@238/js/analytics.min.js,npm/jszip@3/dist/jszip.min.js,npm/@popperjs/core@2.0/dist/umd/popper.js,npm/@fingerprintjs/fingerprintjs-pro@3/dist/fp.min.js,npm/pace-js@1/pace.min.js You could switch it to: @@||cdn.jsdelivr.net^*/pace.min.js$script,domain=starfiles.co|starfiles.ml Or maybe use another method to prevent it from returning false positives in the future.

uBlock-user commented 3 years ago

Ublock once again breaks the website. I just checked and the new URL is:

Can't reproduce, nothing from jsDelivr is blocked as per the logger.

Besure to test on default settings/lists + all other extensions disabled.