uBlockOrigin / uBOL-home

uBO Lite home (MV3)
GNU General Public License v3.0
1.22k stars 50 forks source link

Missing filters from original uBO #128

Closed x-rated closed 3 months ago

x-rated commented 7 months ago

Without the other filters from uBO the blocking results are quite poor 😔 For example seznam.cz, mapy.cz, novinky.cz - detected and not possible to enter, telekomunikace.cz - top ads not blocked etc.

gorhill commented 7 months ago

If you want me to look into this, you need to:

x-rated commented 7 months ago

I have all filters enabled and in case of regional i use cz & sk only, with complete filtering: https://imgur.com/a/jnZWYSq https://www.seznam.cz, https://www.mapy.cz, https://www.novinky.cz and some others from same company: https://i.imgur.com/gWUP0yA.png telekomunikace.cz: https://i.imgur.com/tkNDFVD.png Thank you 🙂

And for comparison I use these filters in uBO https://i.imgur.com/OUOZOa3.png

gorhill commented 7 months ago

Which browser/version is this?

x-rated commented 7 months ago

Chrome 125.0.6422.4 (beta) I usually use stable, but on 124 Skia Graphite flag doesnt work 😐

gorhill commented 7 months ago

With the information you gave me, I can't see any issue. I need the most straightforward way to reproduce on my side, i.e, please do not provide cropped screenshots out of context. I need an exact URL, the screenshot of the page with the problematic section highlighted. Basically, I won't try to guess how to reproduce, I will investigate only if I can reproduce with the details you provide me.

I loaded https://www.seznam.cz/ in the address bar and I can't see anything obvious which resemble an issue when using default list + "EasyList Czech and Slovak" in Optimal mode.

gorhill commented 7 months ago

telekomunikace.cz: https://i.imgur.com/tkNDFVD.png

I can see the banner in your screenshot with uBO, so it's expected it will be also present with uBOL. You need to report to maintainers of EasyList Czech and Slovak.

x-rated commented 7 months ago

after entering seznam.cz (and others mentioned), it redirects to https://cmp.seznam.cz/nastaveni-souhlasu https://i.imgur.com/SZC9zYy.png

and regarding telekomunikace.cz, its this block of ads on top of the page https://i.imgur.com/VaQD4Xk.png but with uBO I dont see any ads there 🤔 https://i.imgur.com/pO2AT3R.png

gorhill commented 7 months ago

after entering seznam.cz (and others mentioned), it redirects to https://cmp.seznam.cz/nastaveni-souhlasu https://i.imgur.com/SZC9zYy.png

Dan Pollock is causing this on my side.

gorhill commented 7 months ago

https://h.seznam.cz/js/cmp2/scmp-cw.js is getting blocked with uBOL, but not with uBO. I have to figure out why.

x-rated commented 7 months ago

oh, yes, but in my case it is Dan Pollock’s hosts file and Steven Black's hosts file too 🤔 i have to turn them off both it might be probably because of older version compared to uBO i guess 🤔

gorhill commented 7 months ago

Dan Pollock contains this entry, h.seznam.cz, so it's expected https://h.seznam.cz/js/cmp2/scmp-cw.js will be blocked. What is not expected is that the same entry with Pollock enabled in uBO is not being blocked.


Ok I see, we have this filter in uBO's base list, ||h.seznam.cz^$badfilter, this prevent the filter in Pollock from being loaded in memory.

badfilter as is not possible in uBOL, except within same list. This complicates things, because to apply badfilter in one list to all other lists requires to compile lists in two passes.

stephenhawk8054 commented 7 months ago

badfilter as is not possible in uBOL, except within same list.

Hmm... Does that mean the badfilter in Unbreak list which tackles other lists is discarded in uBOL?

gorhill commented 7 months ago

which tackles other lists is discarded in uBOL?

It's discarded for other lists not part of the same DNR ruleset, so it works fine for EasyPrivacy, EasyList, Peter Lowe since they are all part of the default ruleset along with uBO's lists. It does not work for Dan Pollock and others. I am a bit surprised though that we have these badfilter entries seemingly addressing issues in non-default lists -- I thought the policy was to not address such issues in Unbreak.

gorhill commented 3 months ago

If a site is broken by a list maintained elsewhere than uAssets, this needs to be fixed in that list. The fact that the issue from an external list was fixed in uBO's default lists, typically this should not be the case.

In short, if Dan Pollocks' h.seznam.cz breaks a website, this needs to be reported and fixed in Dan Pollocks' list.