search

uBlockOrigin / uBOL-home

uBO Lite home (MV3)
GNU General Public License v3.0
1.22k stars 50 forks source link

imdb.com: breakage #185

Closed alturic closed 3 months ago

alturic commented 3 months ago

As the title says, visiting imdb.com with a video on the page (https://www.imdb.com/name/nm0000498/? as an example) results it a mass spam of the video fetches which then leads to getting 503'd for ~minute. I'm unsure if this is something specific to how uBOL works (using all filters but the region-specific ones) or if it's crap JS on the end of imdb.

gorhill commented 3 months ago

Issue is related to the following two filters:

*$media,redirect=noopmp3-0.1s,domain=imdb.com,3p
@@||media-imdb.com^$media,domain=imdb.com

In the conversion to DNR rules, the redirect filter has priority over the exception filter while this should not be the case.

The conversion needs to ensure that exception filters have priority over redirect filters, which is currently not the case.

alturic commented 3 months ago

Thanks for the amazingly quick find! I am curious however, is this something specific to the way imdb is coded or something else? It's the only site that I've seen anything like this happen to.

Also, just out of curiosity, and no I don't expect anything from OSS, is this something that would make the fix in the next update?

gorhill commented 3 months ago

The fix will be in next update, the issue is not converting properly exception filters into DNR rules.

stephenhawk8054 commented 3 months ago

I think this can also be addressed by using to?

*$media,3p,redirect=noopmp3-0.1s,from=imdb.com,to=~media-imdb.com

?

I rebuilt locally with the filter above and I think it works.

gorhill commented 3 months ago

Yes, this will also work. Still need to fix the exception issue though.

gorhill commented 3 months ago

Fixed in uBOLite_2024.8.19.905