uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
945 stars 81 forks source link

Extension report website adblocking option #1541

Closed GKid94 closed 2 years ago

GKid94 commented 3 years ago

Add an option in the extension to report adblocking issues on a website

Felipefpl commented 3 years ago

Good suggestion, adblock plus has this.

unbeatable-101 commented 3 years ago

I’d imagine the button would open to the uAssets tracker

Felipefpl commented 3 years ago

nah, you'd post your problem to a forum without even goin there like it happens with adblock plus.

ghost commented 3 years ago

@gorhill Are you planning to add this feature?

gwarser commented 3 years ago

This will require server/home page, so it will be problematic on privacy side - https://github.com/gorhill/uBlock/wiki/Privacy-policy

You can use existing web-based forms, for example https://reports.adguard.com/en/new_issue.html if you use AdGuard filters.

peace2000 commented 3 years ago

The question is also that for whom those reports should go. Ubo has it's internal filters but mostly it relies heavily on Easylist for adblocking (I think).

Maybe, if this were to be implemented, there could be an option like "report an advertisement" and "report anti-adblock notification". The first could go to Easylist maintainers and the latter to uAssets. (I have impression that uAssets has pretty much specialized anti-adblock stuff which is not allowed on Easylist). (Or do uAssets maintainers want to start "substituting" Easylist? There could be a lot of reports.)

Just thinking out loud.

ghost commented 3 years ago

@peace2000

I have impression that uAssets has pretty much specialized anti-adblock stuff which is not allowed on Easylist

EasyList Cookie + Fanboy’s Annoyance | RU AdList + RU AdList: Counters (although he is not in uBO)

Screen ![2021-07-21_080717](https://user-images.githubusercontent.com/57287308/126434831-aa5b231a-41b7-45c1-8607-378f4253ec1f.png) ![2021-07-21_080803](https://user-images.githubusercontent.com/57287308/126434836-16662156-5397-4948-ad60-70b46ca6927d.png) ![2021-07-21_080813](https://user-images.githubusercontent.com/57287308/126434837-d94810cb-37f6-4d4d-a35a-052f58e2cc7a.png) ![2021-07-21_080837](https://user-images.githubusercontent.com/57287308/126434838-fa1272a7-d7a8-46fd-8ba5-445e95153d02.png) ![2021-07-21_080916](https://user-images.githubusercontent.com/57287308/126434839-40224105-98b2-49c1-a238-ec261cb25098.png)
robinpaulson commented 3 years ago

The question is also that for whom those reports should go.

This is indeed a useful point. However, the mere act of collating those reports/custom filters in one place would be useful. Perhaps ubo would be interested in hosting a list of custom user-generated filters? So long as it's publically available, of course any of the other list providers could include it, perhaps importing by some trivial automatic process,

gwarser commented 3 years ago

Side note / idea: uAssets issue template can be extended to include links to other specialized lists support pages.

gorhill commented 3 years ago

While you discuss, keep in mind I will not:

Feel free to submit solutions which respects those two requirements. If no solution respecting those two requirements is possible, the issue will be closed as declined.

gwarser commented 3 years ago

Whoa there!

Your request URL is too long.

GitHub message

image

gorhill commented 3 years ago

What are the details of the case leading to this?

gwarser commented 3 years ago

What are the details of the case leading to this?

https://github.com/orgs/uBlockOrigin/teams/ublock-issues-volunteers/discussions/292

u-RraaLL commented 3 years ago

Is the new [Create new report] button supposed to now redirect to https://github.com/uBlockOrigin/uAssets/issues/new/choose?

Original url opened:

https://github.com/uBlockOrigin/uAssets/issues/new?title=github.com%3A+privacy&body=%23%23+Address+of+the+web+page%0A%0A%60https%3A%2F%2Fgithub.com%2Fgorhill%2FuBlock%2Fcommit%2Feccf613edfe480d34cb225dac203d3213f3ef2f7%60%0A%0A%23%23+Type+of+issue%0A%0Aprivacy%0A%0A%23%23+Description+%28when+issue+is+not+obvious%29%0A%0A%5Bnone%5D%0A%0A%23%23+Screenshot+%28when+description+is+difficult%29%0A%0A%5Bnone%5D%0A%0A%23%23+Configuration%0A%0A%60%60%60yaml%0AbrowserFlavor%3A+ublock+webext+devbuild+firefox+user_stylesheet+html_filtering+mozilla%0AbrowserVersion%3A+93%0AextensionName%3A+uBlock+Origin%0AextensionVersion%3A+1.38.7b22%0AmodifiedUserSettings%3A+%0A++advancedUserEnabled%3A+true%0A++cloudStorageEnabled%3A+true%0A++firewallPaneMinimized%3A+false%0AmodifiedHiddenSettings%3A+%0A++blockingProfiles%3A+11111%2F%23222+11010%2F%23C0F+11001%2F%2300F+00001%0Afilterset+%28summary%29%3A+%0A++network%3A+79133%0A++cosmetic%3A+39197%0A++scriptlet%3A+16076%0A++html%3A+579%0Alistset+%28total-discarded%2C+last+updated%29%3A+%0A++added%3A+%0Ablock-lan%3A+44-0%2C+3d.22h.35m%0A++default%3A+%0Aublock-filters%3A+30160-30%2C+3d.22h.35m%0Aublock-badware%3A+3167-1%2C+3d.22h.35m%0Aublock-privacy%3A+178-0%2C+3d.22h.35m%0Aublock-abuse%3A+67-0%2C+3d.22h.35m%0Aublock-unbreak%3A+1697-0%2C+3d.22h.35m%0Aeasylist%3A+60341-517%2C+3d.22h.35m%0Aeasyprivacy%3A+25471-209%2C+3d.22h.35m%0Aurlhaus-1%3A+10790-0%2C+11h.48m%0Aplowe-0%3A+3675-2%2C+3d.22h.35m%0Afilterset+%28user%29%3A+%5Barray+of+298+redacted%5D%0AswitchRuleset%3A+%0A++added%3A+%5Barray+of+1+redacted%5D%0AhostRuleset%3A+%0A++added%3A+%5Barray+of+98+redacted%5D%0A%0A%60%60%60%0A

But it doesn't fill in any issue details, just redirects to the issue choice page (losing the details).

Same thing happens regardless of the type of issue chosen on the report page.

gwarser commented 3 years ago

@u-RraaLL seems fine for me.

u-RraaLL commented 3 years ago

@gwarser is it possible that as a member/collaborator your account is not forced to use a template?

gorhill commented 3 years ago

The old UI is deprecated, I won't spend time on it unless it's trivial fixes.

gorhill commented 3 years ago

But it doesn't fill in any issue details, just redirects to the issue choice page (losing the details).

Hmmm I see blank_issues_enabled: false in the config file.

u-RraaLL commented 3 years ago

It's working correctly now. Thanks.

Just as a follow-up - have you considered, on the report page:

  1. Adding a line suggesting updating filter lists.
  2. Asking to test on default settings/filter lists.

I know the 2nd one is in the issue template, but considering some people will have to register new accounts to file issues, it might be wise for them to verify such things beforehand.

gorhill commented 3 years ago

I first want to test with users being able to create issues with as little friction as possible, then will evaluate as the report feature is used. One of the key missing information was about the config and now it's there, this will make it much easier for volunteers to narrow down issues. One thing I could add is an entry about whether a user's custom filters/rules (if any) are affecting the web page reported as having issues.

YoshiTabletopGamer commented 2 years ago

I'm testing uBO 1.38.7.rc1, and I think it would be nice to put the Troubleshooting Information options on the "Report a Filter Issue" interface too Interface of Report a Filter Issue uBO 1 38 7rc1

gorhill commented 2 years ago

It's automatically added to the GitHub template. I want to keep the UI as simple as possible.

mtxadmin commented 2 years ago

Will report feature be available for non-default lists?

gorhill commented 2 years ago

The template says:

To avoid burdening volunteers with invalid issues: ... You may be asked to verify that the issue still occurs when using only default filter lists.

ghost commented 2 years ago

@gorhill Add tags for screenshots. https://github.com/uBlockOrigin/uAssets/issues/10517

gorhill commented 2 years ago

Add tags for screenshots.

No need, just drag and drop an image in the Screenshot section will automatically upload the image and create markdown code to render it properly.

ghost commented 2 years ago

No need, just drag and drop an image in the Screenshot section

What if there are 5+ images?

gorhill commented 2 years ago

Just drag and drop 5 images.

ghost commented 2 years ago

Just drag and drop 5 images.

OK, but with tags this are more compact.

gorhill commented 2 years ago

Screenshots are optional, I can't add <details></details> tags unconditionally.

YoshiTabletopGamer commented 2 years ago

@gorhill

I have attached a screenshot of the Ublock Origin 1.38.7.rc1 Support tab:

Ublock Origin Support Menu

The Support Tab is a good feature, but its interface does not inform the user that the Troubleshooting Information is automatically sent to the GitHub template when clicking Open on Filter issues/website is broken and Bug report.

Other content blockers, such as, for example, Adguard, acknowledge on their privacy policy that information is sent to a report form when using their report website feature:

Sending a web page complaint

User can submit a report on a problem with a website right from the app. The app will automatically open reports.adguard.com web page and forward some information about its configuration. User can then alter or delete it.

However, you said you would not change Ublock Origin's privacy policy for this feature to be implemented.

Shouldn't users be informed (through the interface) that Troubleshooting Information is sent to GitHub when clicking Open on Filter issues/website is broken and Bug report?

gorhill commented 2 years ago

Adguard, acknowledge on their privacy policy

AdGuard sent the information to its own server.

I don't own GitHub, and the support page warns that a GitHub account is required.

YoshiTabletopGamer commented 2 years ago

I must have misexplained: I'm talking about the sending of information (added by Ublock Origin) like in this configuration parameter:

https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FuBlockOrigin%2FuAssets%2Fissues%2Fnew%3Ftemplate%3Dreport_from_ubo.yml%26configuration%3D%2560%2560%2560yaml%250AuBlock%2BOrigin%253A%2B1.38.7rc1%250AChromium%253A%2B96%250Afilterset%2B%2528summary%2529%253A%2B%250A%2B%2Bnetwork%253A%2B81145%250A%2B%2Bcosmetic%253A%2B38670%250A%2B%2Bscriptlet%253A%2B16176%250A%2B%2Bhtml%253A%2B0%250Alistset%2B%2528total-discarded%252C%2Blast%2Bupdated%2529%253A%2B%250A%2B%2Bdefault%253A%2B%250A%2B%2B%2B%2Beasylist%253A%2B59761-5%252C%2B1h.32m%250A%2B%2B%2B%2Beasyprivacy%253A%2B25411-7%252C%2B1h.32m%250A%2B%2B%2B%2Bplowe-0%253A%2B3689-543%252C%2B1h.32m%250A%2B%2B%2B%2Bublock-abuse%253A%2B67-0%252C%2Bnever%250A%2B%2B%2B%2Bublock-badware%253A%2B3356-54%252C%2Bnever%250A%2B%2B%2B%2Bublock-filters%253A%2B29594-74%252C%2Bnever%250A%2B%2B%2B%2Bublock-privacy%253A%2B185-1%252C%2Bnever%250A%2B%2B%2B%2Bublock-unbreak%253A%2B1685-39%252C%2Bnever%250A%2B%2B%2B%2Burlhaus-1%253A%2B13106-0%252C%2Bnever%250Afilterset%2B%2528user%2529%253A%2B%255Bempty%255D%250AmodifiedUserSettings%253A%2B%255Bnone%255D%250AmodifiedHiddenSettings%253A%2B%255Bnone%255D%250AsupportStats%253A%2B%250A%2B%2BlaunchToReadiness%253A%2B925%250A%2B%2BlaunchFromSelfie%253A%2Bfalse%250A%250A%2560%2560%2560%250A

I know this information is very useful to the volunteers, but the user is not informed in the Support Tab that the Troubleshooting Information

uBlock Origin: 1.38.7rc1
Chromium: 96
filterset (summary): 
  network: 81145
  cosmetic: 38670
  scriptlet: 16176
  html: 0
listset (total-discarded, last updated): 
  default: 
    easylist: 59761-5, 1h.32m
    easyprivacy: 25411-7, 1h.32m
    plowe-0: 3689-543, 1h.32m
    ublock-abuse: 67-0, never
    ublock-badware: 3356-54, never
    ublock-filters: 29594-74, never
    ublock-privacy: 185-1, never
    ublock-unbreak: 1685-39, never
    urlhaus-1: 13106-0, never
filterset (user): [empty]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  launchToReadiness: 925
  launchFromSelfie: false

is sent. The Troubleshooting Information section just says:

Below is technical information that might be useful when volunteers are trying to help you solve a problem.

Important: Potentially private or sensitive information is redacted by default. Redacted information may make it more difficult to solve a problem.
gorhill commented 2 years ago

The configuration is redacted, and there is nothing specific in it which is of any use outside filter list volunteers, I fail to understand you worrying about this information while the URL of where there is an issue does tell something specific about you.

YoshiTabletopGamer commented 2 years ago

I've changed my mind. You're right.

krystian3w commented 2 years ago

Screenshots are optional, I can't add <details></details> tags unconditionally.

AdGuard still use empty details:

2. Screenshots
<details><summary>Screenshot 1:</summary>

<!-- paste screenshot here -->

</details>

<details><summary>Screenshot N:</summary>

<!-- paste screenshot here -->

</details>

Also github may fail test to check html5 on site, so possible ignore non-sematic empty tags in issues:

https://validator.w3.org/nu/?doc=https%3A%2F%2Fgithub.com%2FuBlockOrigin%2FuBlock-issues%2Fissues%2F1541

gorhill commented 2 years ago

Maybe GitHub Actions can solve this and automatically add the tags whenever a screenshot link is detected: https://github.com/marketplace/actions/create-or-update-comment. Whoever is welcome to research this and suggest a solution.

jidanni commented 2 years ago

OK, I am working through the form,

Report a filter issue
Report filter issues with specific websites to uBlockOrigin/uAssets issue tracker. Requires a GitHub account.

OK, at this point, there should be a sentence explaining what the rest of the form is for, before, or just after, we reach

To avoid burdening volunteers with duplicate reports, please verify that the issue has not already been reported.

So maybe say For non-specific website reports, continue below or something... but that doesn't make sense...

jidanni commented 2 years ago

Also the please verify that the issue has not already been reported perhaps should be combined with the button at bottom that says Find similar reports.

But: genuine bug about that Find similar reports button: If the user changes what is in the Address of the web page: textbox, those changes are ignored when he presses the Find similar reports button! E.g., if he changes example.com to deadly.example.net, the form will still look for example.com reports!

jidanni commented 2 years ago

Same problem with the Create new report button! So what need would the user have to change example.com to deadly.example.net? Well just like a crime victim does not want to always need to return to the exact site of the crime to file a report.

JohnyP36 commented 2 years ago

The old UI is deprecated, I won't spend time on it unless it's trivial fixes.

But I still use the old UI, because I don't like the new one.

krystian3w commented 2 years ago

Some people still change config pool into one dot.

robinpaulson commented 2 years ago

This conversation got very weird and off-topic, i entirely understand why the repo owner closed, if nothing else to stop the noise.

I think a number of participants made it a whole lot more complicated than it needs to be. This was the idea/model I had; it's hard to pick out the signal amidst the noise, so I can't tell if this was suggested and discussed already:

  1. A user of uBO goes to a website
  2. They see an advert/other problematic item which is not blocked
  3. They use the uBO drop down menu (new or old UI, I really don't care which.....that discussion was total "bikeshedding") to block the offending element
  4. In the case they have ticked "Automatically report manual element blocks", the blocked element is added to a list of "items to be checked", somewhere remotely (details to be decided upon later, yes this is important, yes I accept the statements by gwarser about not wishing to host a server or change the privacy policy)
  5. Volunteers look through the list and decide whether it is a problematic element, and whether to add it to a blacklist or whether to ignore it.
  6. No need for forms to fill out, or any other useless busy-work.
u-RraaLL commented 2 years ago

The issue was closed as fixed, not "due to noise".

Your idea would be declined, because, like you mentioned, it'd require a server and a change to the privacy policy.

It would also be prone to getting abused. And wouldn't account for site breakages or anti-adblocking measures such as blocking the context menu, etc.

garry-ut99 commented 1 year ago

Hundreds of spam issues littering the uAssets issue tracker, marked as duplicate and closed:

I wonder whether would it be possible that uBO Report Panel could simply detect: youtube, twitch, facebook domains in the URL (domain) of the reported website and then cause "Create New Report" button to open one of big "ALL issues" uAssets thread, instead opening "New Issue template", that way we could prevent creating these duplicates: SCREENSHOOT

UPDATE: as I see that even big threads are sometimes closed and locked due to the limit of comments, and then replaced by new ones: LINK 1, in such case instead of providing a link to every specific active big thread, which changes from time to time, the link can be universal (example for youtube): LINK 2 - it will always lead to the currently active big youtube thread.