uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
944 stars 80 forks source link

Incomplete i18n in the logger #1888

Open ghost opened 2 years ago

ghost commented 2 years ago

Prerequisites

I tried to reproduce the issue when...

Description

This issue is partly a duplicate of https://github.com/uBlockOrigin/uBlock-issues/issues/394, but I think it should be separate for brevity. The strings marked in the screenshot below is not translatable in Crowdin. It seems to be an easy job, just boring, so I've prepared a patch. Please use it if you have no problems.

Screenshot

A specific URL where the issue occurs

https://old.reddit.com/r/uBlockOrigin/

Steps to Reproduce

  1. Switch Firefox locale to a language where uBO's translation is 100% on Crowdin.
  2. Open the logger.

Expected behavior

You will see 100% localized strings.

Actual behavior

There is a mixture of translated and untranslated UI.

Configuration

```yaml uBlock Origin: 1.39.3rc0 Firefox: 95 filterset (summary): network: 77641 cosmetic: 39254 scriptlet: 16228 html: 595 listset (total-discarded, last updated): default: ublock-filters: 30358-107, never ublock-badware: 3569-1, never ublock-privacy: 177-0, never ublock-abuse: 72-0, never ublock-unbreak: 1694-0, never easylist: 60746-79, never easyprivacy: 25518-27, never urlhaus-1: 8813-0, never plowe-0: 3689-560, never filterset (user): [empty] modifiedUserSettings: [none] modifiedHiddenSettings: [none] supportStats: launchToReadiness: 1402 ms ```
gorhill commented 1 year ago

I can't translate the filter expressions, these match what the logger reports, and the logger reports technical information which should not be translated, most of what is there can be used as is as filter options (i.e. *$media, etc.) The only string meant to be localized is click to preview.