Ublock 1.41.2 update ignores 'my filters'

reaper666735 commented 2 years ago

Prerequisites

[X] I verified that this is not a filter issue (MUST be reported at filter issue tracker)
[X] This is not a support issue or a question
[X] I performed a cursory search of the issue tracker to avoid opening a duplicate issue
[X] The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
[X] I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

[X] uBO is the only extension
[X] uBO with default lists/settings
[X] using a new, unmodified browser profile

Description

since the latest update items i choose in the element picker mode (who end up in my filter list) are not being hidden anymore, reverting back to 1.40.8 fixes this issue

A specific URL where the issue occurs

https://outlook.live.com/mail/inbox

Steps to Reproduce

Use element picker mode
Add [ outlook.live.com##.f1vx9l62.f124akge.f1l02sjl.f1ctqxl6.f122n59.f22iagw.___lluazi0 ] and or [ outlook.live.com##._1elFdDtE02urszo_h9-MJw.full ] to the list (it's just a sidebar and banner frame)
After reload or browser restart they are back

Expected behavior

well i expected it to be hidden even after reload :p

Actual behavior

it seems to stay as long as you don't leave the page, otherwise it seems to not load from my filter list

uBlock Origin version

1.41.2

Browser name and version

Waterfox (G4.0.7)

Operating System and version

win 10 21h2

coldimmune commented 2 years ago

All my mobile devices use Firefox Android 68 and experienced the same issue -- the 1.41.5b1 fixed it.

It may be outdated and unsupported, but in my defense, Fenix should be classified as beneath us. Just a dogshit browser.

_Edit: Just came back here to thank you profusely for your work on Ublock Origin and having a fix for such an obscure issue on EOL browsers in only a few days. And for something that's free. My work can't do that for customers.

It's just such a Quality of Life improvement with something I use a hundred times a day. And you never screw around with the GUI or make major, powertripping changes. Like, the only step forward from here would be in 50 years when we're using augmented bionic eyes and you're still around, creating a tool to block affronts from our real vision._

Candlemass commented 2 years ago

I was having the same problem on Android mobile 68.x (Dont use the shitty new fenix verson). Reverting to 1.40.8 solved the problem but didnt have dark mode so I settled on 1.14.6 since it`s the latest stable version with that feature and so far seems to be resolved. I will report back if this changes for any reason.

Its more apparent than ever why a lot of users dont upgrade once they find something that works. Far too much breakage occurring these days of essential features in exchange of implementing new ones...

HoldOffHunger commented 2 years ago

SOLVED.

--Remove uBlock Origin --Install uBlock Origin v. 1.18.17.16 from here https://www.crx4chrome.com/crx/149207/

I like how this problem is super easy to reproduce and demonstrate. But I like a lot better having the solution!

e-t-l commented 2 years ago

I was having the same issue on some sites, including Reddit, and updating to v1.44.5b6 did fix the issue with Element Picker-created filters not persisting across page refreshes.

@gorhill You might like to know, however, that after updating UBO I encountered a separate issue: ALL elements of Reddit were blocked (aka when the page finished loading, it was blank white) until I a) disabled cosmetic filtering on Reddit (not ideal), or b) checked Ignore Generic Cosmetic Filters in UBO settings (still problematic, because I'd like generic filters to apply to most sites).

gorhill commented 2 years ago

Just force a purge all cache then update now to ensure all your filters are recompiled with using the latest fixes.

e-t-l commented 2 years ago

@gorhill Now this is strange. I'm on v1.44.5b6, I purged and updated caches, but my Element Picker-created filter on Reddit is still not working! I'm no longer encountering a totally blank page, though. When I disable cosmetic filtering on Reddit, it still doesn't work (aka the element is not blocked). However, when I check Ignore Generic Cosmetic Filters in UBO settings, suddenly my filter does work, and the annoying element is blocked! I have no idea how to diagnose this further.

gorhill commented 2 years ago

Share troubleshooting information, and which filter you say is not working when "Ignore Generic Cosmetic Filters" is not checked.

e-t-l commented 2 years ago

Affected filter: www.reddit.com##.kEQVd8aneM1tVkcIKUyDT

Troubleshooting information:

uBlock Origin: 1.44.5b8
Firefox: 105
filterset (summary): 
  network: 388117
  cosmetic: 164875
  scriptlet: 39004
  html: 779
listset (total-discarded, last-updated): 
  added: 
    https://gitcdn.xyz/repo/NanoAdblocker/NanoFilters/master/NanoFilters/NanoBase.txt: 0-0, 19h.13m
    https://gitlab.com/curben/urlhaus-filter/raw/master/urlhaus-filter.txt: 155490-2442, 19h.13m
    https://raw.githubusercontent.com/AFNIL-AntiFakeNewsInternationalList/AFNIL/master/AFNIL-ABP-uBO.txt: 5794-1562, 19h.13m
    https://raw.githubusercontent.com/NanoAdblocker/NanoFilters/master/NanoMirror/NanoDefender.txt: 2625-20, 19h.13m
    https://raw.githubusercontent.com/Spam404/lists/master/adblock-list.txt: 7252-143, 19h.13m
    https://raw.githubusercontent.com/austinheap/sophos-xg-block-lists/master/add-dead.txt: 20-0, 19h.13m
    https://raw.githubusercontent.com/austinheap/sophos-xg-block-lists/master/add-risk.txt: 2567-5, 19h.13m
    https://raw.githubusercontent.com/austinheap/sophos-xg-block-lists/master/add-spam.txt: 73-0, 19h.13m
    https://raw.githubusercontent.com/deathbybandaid/piholeparser/master/Subscribable-Lists/ParsedBlacklists/ABP-Clickbait-Blocklist.txt: 12-0, 19h.13m
    https://raw.githubusercontent.com/deathbybandaid/piholeparser/master/Subscribable-Lists/ParsedBlacklists/BreakingTheNews.txt: 1-0, 19h.13m
    https://raw.githubusercontent.com/marktron/fakenews/master/fakenews: 2197-2, 19h.13m
    https://raw.githubusercontent.com/ryanbr/fanboy-adblock/master/fake-news.txt: 584-242, 19h.13m
    https://raw.githubusercontent.com/yourduskquibbles/webannoyances/master/filters/newsletter_filters.txt: 2027-2, 19h.13m
    https://s3.amazonaws.com/lists.disconnect.me/simple_malvertising.txt: 2735-48, 19h.13m
    https://winhelp2002.mvps.org/hosts.txt: 8730-738, 19h.13m
    https://www.fanboy.co.nz/enhancedstats.txt: 2989-67, 19h.13m
    adguard-generic: 70138-5615, 19h.14m
    adguard-spyware: 26705-1614, 19h.14m
    curben-phishing: 75328-5, 19h.14m
    adguard-annoyance: 59684-5440, 19h.14m
    [8 lists not shown]: [too many]
  default: 
    user-filters: 49-4, never
    ublock-filters: 33694-379, 19h.15m
    ublock-badware: 4324-6, 19h.14m
    ublock-privacy: 273-1, 19h.14m
    ublock-abuse: 76-0, 19h.14m
    ublock-unbreak: 1875-2, 19h.14m
    easylist: 62254-18655, 19h.14m
    easyprivacy: 30638-14428, 19h.14m
    urlhaus-1: 7155-0, 19h.14m
    plowe-0: 3670-1800, 19h.13m
filterset (user): [array of 49 redacted]
trustedset: 
  added: [array of 73 redacted]
  removed: 
    edge-scheme
switchRuleset: 
  added: [array of 30 redacted]
hostRuleset: 
  added: [array of 15 redacted]
modifiedUserSettings: 
  advancedUserEnabled: true
  cloudStorageEnabled: true
  contextMenuEnabled: false
  ignoreGenericCosmeticFilters: true
  webrtcIPAddressHidden: true
modifiedHiddenSettings: 
  autoUpdateAssetFetchPeriod: 120
  autoUpdatePeriod: 7
  selfieAfter: 11
  userResourcesLocation: [redacted]
supportStats: 
  allReadyAfter: 68901 ms (selfie)
  maxAssetCacheWait: 19384 ms

gorhill commented 2 years ago

You have way too many filter lists for me to spend time on trying to reproduce. I suggest to disable a few filter lists at a time and see if this solve your issue. If so, please report which filter list seems to trigger the issue. Also, you are still subscribed to filter lists which have been abandoned since a long time, you need to clean up your config.

e-t-l commented 2 years ago

please report which filter list seems to trigger the issue

Can do. Sorry, didn't mean to act like I was dumping a huge task on you. You asked for troubleshooting info so I copied and pasted. I don't really know what I'm looking for - But why would another filter from a filter list cause mine not to work? Is there some order of precedence I'm not understanding (and if so, shouldn't it be reversed? Seems like the user's My Filters should override anything in an imported list, shouldn't it?)

still subscribed to filter lists which have been abandoned since a long time

How do I tell which ones are abandoned? And does abandoned mean none of the filters are relevant anymore?

gorhill commented 2 years ago

How do I tell which ones are abandoned?

Open the list in a tab. If it does not load, remove it. If it loads, check the last time it was updated. If it's more than a year, it's useless and may interfere negatively. When it comes to filter lists, more is not better. Some of these abandoned lists might be at the root of the long load time issue I can see in your troubleshooting information. Probably best to reset to default lists and add lists only when it actually do solve an actual issue you are trying to solve. Maybe it's the long load issue which cause you to misdiagnose a filter issue, it took over 1 minute for uBO to be ready (allReadyAfter).

e-t-l commented 2 years ago

Thanks.

Open the list in a tab. If it does not load, remove it. If it loads, check the last time it was updated.

Do I need to do this with ALL lists (including the ones uBlock ships with) or only for the lists I have added under the Custom heading?

Probably best to reset to default lists

Likewise, does "default" mean any/all of those non-Custom lists, or only the ones UBO has enabled upon fresh install?

MasterKia commented 2 years ago

or only for the lists I have added under the Custom heading?

This.

or only the ones UBO has enabled upon fresh install?

This. You can use the "Reset to default settings" option in the first tab of options.

gorhill commented 2 years ago

@e-t-l Reset to default settings will cause your custom filters in My filters/My rules/Trusted sites to be wiped out so you may want to export them first.

gorhill commented 2 years ago

By the way, I would still like to know what list is causing your cosmetic filter to stop working, there has been changes in this area in the latest dev builds, and this might just help me fix a difficult to reproduce issue. Narrowing down to which list would help a lot. If it's not a specific list, it could be your own cosmetic filter, see if commenting them out make the affected filter working again.

e-t-l commented 2 years ago

Ah. Sorry. I had gone thru the lists and removed the ones that didn't load or were over a year old, but I didn't stop to refresh reddit and see if it was affected each time. At this point, my cosmetic filter is working again.

I only did this with Custom Lists and have not disabled any of the UBO-included lists, so we can safely say none of those are the issue.

I think I could re-add them incrementally, since I have their names in the troubleshooting output in my previous comment, and then test reddit to see if I can narrow it down.

uBlockOrigin / uBlock-issues