uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
945 stars 81 forks source link

anilibria.tv: breakage #2002

Closed JAKill02 closed 2 years ago

JAKill02 commented 2 years ago

Prerequisites

URL address of the web page

https://www.anilibria.tv/release/platinum-end.html

Category

breakage

Describe the issue

completely breaks the appearance of the page.

Screenshot(s)

Screenshot(s)

Configuration

```yaml uBlock Origin: 1.41.2 Chromium: 86 filterset (summary): network: 95921 cosmetic: 63037 scriptlet: 18031 html: 0 listset (total-discarded, last updated): default: user-filters: 119-6, never RUS-0: 41445-9, 5m easylist: 63806-21, 5m easyprivacy: 26606-221, 4m plowe-0: 3670-810, 6m ublock-abuse: 77-1, 4m ublock-badware: 4018-76, 4m ublock-filters: 30245-173, 4m ublock-privacy: 199-2, 6m ublock-unbreak: 1715-39, 6m urlhaus-1: 6641-0, 6m filterset (user): [array of 130 redacted] trustedset: added: [array of 20 redacted] removed: chrome-extension-scheme chrome-scheme switchRuleset: added: [array of 101 redacted] modifiedUserSettings: webrtcIPAddressHidden: true modifiedHiddenSettings: [none] supportStats: allReadyAfter: 48143 ms (selfie) maxAssetCacheWait: 726 ms popupPanel: blocked: 11 blockedDetails: digitalcaramel.com: 1 googletagmanager.com: 1 jsdelivr.net: 2 mail.ru: 1 static.anilibria.tv: 3 utarget.ru: 1 yandex.ru: 2 ```
mapx- commented 2 years ago

Update your browser, test disabling all other extensions

Procyon-b commented 2 years ago

@mapx- I've tried with an old browser (chrome 70) and I don't see any problem.

@JAKill02 you have 130 user filters. Try without them. Go to the "Filter lists" tab and uncheck "My filters", click "Apply changes". Reload the website. If it's fixed, re-enable "My filters" and check them one by one. Also look at ublock's popup window on the site's tab to see if you have disabled some elements (you have 101 rules)

dimisa-RUAdList commented 2 years ago

@gorhill For some reason, the third-party option is too strict on this site. Try adding ||static.anilibria.tv^$third-party and open https://www.anilibria.tv/. The site will be broken, and the following will be in the logger: https://i.imgur.com/bxJyDuC.jpg

The problem is observed in Chromium-versions 1.41.2 - 1.41.7b1 downloaded from here: https://github.com/gorhill/uBlock/releases and also in version 1.41.7.0 downloaded from here: https://chrome.google.com /webstore/detail/ublock-origin-development/cgbcahbpdhpcegmbfconppldiemgcoii

gorhill commented 2 years ago

From what I see so far, *.tv seems to be deemed a Public Suffix. I don't know why as I can't find an entry in the official PSL, need to investigate more.

gwarser commented 2 years ago

WTF? I was able to repro so I started bisecting lower and lower versions and then it stopped around 1.18 and I cannot reproduce anymore.

gorhill commented 2 years ago

This looks like this might be a lengthy investigation -- for now maybe just use ||static.anilibria.tv^$domain=~anilibria.tv.

gorhill commented 2 years ago

@gwarser Are you using a new uBO install for each bisect to be sure the selfie is not being used every time?

gwarser commented 2 years ago

Ok, it breaks again after copy-pasting the URL from above message into new Chrome tab. Previously I did modified the filter in My filters by removing, saving and adding back characters and saving again, then force-reloading the tab.

I have it broken in 1.20.0 right now.

dimisa-RUAdList commented 2 years ago

In fact, to fix the break, I had to edit the rule against disposable adservers, removing anilibria.tv from the list of target domains: https://github.com/easylist/ruadlist/commit/53d39cb6349f86a1517498fda943fc37910508e1

gwarser commented 2 years ago

1.18 was fine, 1.19 - fine, back to 1.20.0 and it's fine ;D

gorhill commented 2 years ago

had to edit the rule against disposable adservers

But I didn't use RUAdList.

Furthermore, when I add tests to PSL library, all passes:

checkPublicSuffix('www.anilibria.tv', 'anilibria.tv');
checkPublicSuffix('static.anilibria.tv', 'anilibria.tv');

So I have no clue what is going on.

gwarser commented 2 years ago

Cannot reproduce if I clean browsing data and install fresh uBO.

But updating all lists in fresh 1.41.5.2 install broke it.

Something between 1.20 and 1.30?

Hmmm, broken, not updating, malware lists (and "Online Malicious URL Blocklist" after assets update) prevent this from happening? After removing them, it's reproducible in 1.26.1b1. v1.22.5b4. v1.21.7b4. v1.20.0.

Seems fine on v1.18.0

gwarser commented 2 years ago

Introduced in https://github.com/gorhill/uBlock/commit/4da340384ae0697d3083523d95253a3506b0aecf

gorhill commented 2 years ago

when I add tests to PSL library, all passes

All tests pass with the bundled PSL. When I replace the bundled list with the latest one from PSL dot org, the two tests fail.

gwarser commented 2 years ago

// newGTLDs

// List of new gTLDs imported from https://www.icann.org/resources/registries/gtlds/v2/gtlds.json on 2022-02-18T15:13:38Z // This list is auto-generated, don't edit it manually. // aaa : 2015-02-26 American Automobile Association, Inc. aaa ...

gorhill commented 2 years ago

I think the flaw in the code is that it's not ready to deal with related PSL entries which are spread throughout the list. tv is such one case.

gwarser commented 2 years ago

https://github.com/publicsuffix/list/commits/master/public_suffix_list.dat

gorhill commented 2 years ago

Ok I found the issue. It's very unlikely to be triggered, but it can happen, and it did happen eventually as shown here.