Open krystian3w opened 2 years ago
Doesn't gorhill decline issues based just on proof on concept instead or real cases?
Maybe but what happens when these pop-ups start cover 99% of Internet or start used to disable use element picker (small ads in sidebar without backdrop).
Pages started use dialogs:
https://github.com/uBlockOrigin/uAssets/commit/0196844770969c05b586943be79faa3a6d36ddbf
My bad. I was still on FF 97.0.2 and wasn't affected.
If I understood this issue correctly, the same behavior can be seen on this link:
https://en-us.topographic-map.com/map-vx51/San-Francisco/?center=37.90303%2C-121.83254&zoom=12
The picker won't become visible. Caused by GDPR dialog.
I see similar behaviour with a consent dialog at https://computerbase.de.
My workaround is to manually enter a filter rule that blocks dialogs, like so:
! computerbase is using dialog elements to prevent element picker from working
computerbase.de##dialog
The funny thing about this is that using a dialog element makes blocking the whole consent mechanism much cleaner and easier. But it would be nice if the element picker could handle it.
(Of course, blocking all dialog elements is an extreme solution and not an option if the site uses dialogs for anything that's actually useful to the user, but the filter can be made more granular with class designators.)
but the filter can be made more granular with class designators
Worse as they will drive us into a corner when the attribute name is not stable and the value is - not everyone has yet learned to use :matches-attr
and not everyone reads the wiki.
Popover also is danger:
test: https://gistcdn.githack.com/krystian3w/4ebb7b77634d94a9b2f7238dcee32947/raw/index2.html
(On the plus side of the attribution is the requirement for a genuine click (only someone needs to check that they detect fake clicks in JS - if there is no detection of whether the user has clicked, I would equate it with the dialogue tag))
If the dialog is modal (shown with .showModal()
), then blocking it with uBlock doesn't help. The dialog doesn't show up, but the page becomes non-interactive. You can scroll, but cannot interact with it, and certainly cannot use the element picker.
Hi. Apologies if this isn't related (though it is somewhat similar, and for some-reason I cannot create a new ticket on this site as it says the owner hasn't granted permission) but... could a countdown-timer mode be added to the Element Picker?
I'm unsure otherwise how to block "hover-over" type elements, and on some websites I accidentally mouse-over some elements and they take too-long to disappear. Could a countdown be added, similar to the Windows "Snipping Tool" where after 10 seconds it would then dim the site and keep any hover-over elements in-place so they can be selected?
Thanks
@dftf-stu Concerning that matter, please open a separate discussion thread here: https://github.com/uBlockOrigin/uBlock-issues/discussions
Simple hover possible delay/froze by browser devtools, harder like on Apple web pages need script to generate "hover" action in DOM.
Not sure if this is completely related but when visiting zoomit.ir
, there's a popup that prevents modifying the text inside the element picker but the buttons and sliders still and work.
https://github.com/user-attachments/assets/ef933450-883e-40b6-980c-2b5727650660
After closing the popup the issue goes away.
The page is constantly calling code with a setTimeout
with a delay of 0
, not sure what it's doing but this removes the issue:
zoomit.ir##+js(prevent-setTimeout, addEventProcessor)
Prerequisites
I tried to reproduce the issue when...
Description
New native dialog pop-ups is rendered higher than element picker iframe, so if element is selected then no possible click in "create" button. Similar to #1098, #987
AdGuard freeware Addon have similar limitation as long use iframe
#adguard-assistant-dialog
.A specific URL where the issue occurs
https://gistcdn.githack.com/krystian3w/4ebb7b77634d94a9b2f7238dcee32947/raw/index.html or https://gistcdn.githack.com/krystian3w/4ebb7b77634d94a9b2f7238dcee32947/raw/index2.html
real world cases:
https://www.blogmojo.de/chatgpt-alternative/
indagare.com
computerbase.de
https://en-us.topographic-map.com/map-vx51/San-Francisco/?center=37.90303%2C-121.83254&zoom=12
https://www.warzywapolowe.pl/
Steps to Reproduce
Expected behavior
z-index: auto
so I cannot found method)Actual behavior
uBlock Origin version
1.58.1b12
Browser name and version
Firefox 128.0
Operating System and version
Windows 11 Pro 23H2