uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
947 stars 81 forks source link

"My Filters" section of the settings is pretty bugged on Android #2326

Open Palloxin opened 2 years ago

Palloxin commented 2 years ago

Prerequisites

I tried to reproduce the issue when...

Description

  1. the text selector does what it wants only in this extension (see the video) https://user-images.githubusercontent.com/75091899/196031329-4fb18f16-59c0-4884-bcd6-60f67d2054b8.mp4

  2. it is hard to delete lines of code, i try to use the delete button of the keyboard and lines are not delete. https://user-images.githubusercontent.com/75091899/196031206-4fd79c1c-a40d-42c3-a10c-8d5b6ba8f0c1.mp4

  3. when i delete the code of some website with the keyboard the postion of the text that is currently deleted changes randomly(see video) https://user-images.githubusercontent.com/75091899/196031077-b59abe46-ed42-4066-bae0-c682a55dd709.mp4

A specific URL where the issue occurs.

moz-extension://a4836e20-4ce6-4223-bdb1-e66028cb4b97/dashboard.html#1p-filters.html

Steps to Reproduce

videos in the description

Expected behavior

normal behaviour of a "text" editor

Actual behavior

my filters editor bugged, hard to manage the code

uBO version

1.44.4

Browser name and version

Firefox mobile

Operating System and version

Android 8 Miui 8

ghajini commented 2 years ago

https://github.com/uBlockOrigin/uBlock-issues/issues/1716#issuecomment-917423757 use anysoftkeyboard

https://play.google.com/store/apps/details?id=com.menny.android.anysoftkeyboard

Palloxin commented 2 years ago

@ghajini I tried it, but the themes are ugly. I used another keyboard called Florisboard, highly customizable keyboard open source, and the problems are still there

ghajini commented 2 years ago

Using anysoftkeyboard

I can reproduce your description point 1 and i guess you want to copy the filter, just click on gutter start of filter, that serves the purpose

& for your other problems try disabling show suggestions & auto-capitalization feature in aosp keyboard settings...

Palloxin commented 2 years ago

@ghajini i forgot to say that your keyboard doesn't bug "my filters" code editor. anyway the bug is still there , and it happens with the most used keyboard on android. thus i would say it is a problem

krystian3w commented 2 years ago

2146 - but may no possible easy test without use Firefox nightly if gorhill in free time rewrote highlight.

MasterKia commented 1 year ago

https://github.com/uBlockOrigin/uBlock-issues/issues/2805: Improvement For Mobile Users Should Be Made Or Atleast Better Compatibility With Gboard ? There Is Problems With Normal Select Too ScreenRecord - https://www.veed.io/view/d15459ad-eacb-4747-b0c5-7f075f091b82?sharingWidget=true&panel=

BlazeFTL commented 1 year ago

Screenshot_20231116-110311_crDroid_Home Topbar Not Visible In FireFox If Bottom Search Bar Is Used(For Chrome Top/Bottom Doesn't Matter)

gwarser commented 1 year ago

@BlazeFTL ok, I can reproduce this one. Not related to toolbar position for me. I think it happens when uBO is restoring the cursor position to the bottom of a long list of filters. Does not happen for 3-4 filters, but after restoring my backup with hundreds of lines, then placing the cursor at the bottom, I was able to reproduce. I was able to fix by putting the cursor in the first line, close the tab and open again. This does not always work, probably because the cursor position is saved after a delay.

@gorhill ?

Palloxin commented 1 year ago

If it can help i had a similar problem on another app with the cursor position doing weird stuff and it happened only on miui https://github.com/LNReader/lnreader/issues/654 This has been fixed and maybe it can help. In that issue a guy with A12 and miui 13 had the same problem so i guess there is a link.

BlazeFTL commented 1 year ago

Yes Problems Can Increase Depending On Android Version Or Rom...https://github.com/uBlockOrigin/uBlock-issues/issues/2805 The Video Attached There Was a A11 Rom But 95% Issues Was Solved On A13 Rom

garry-ut99 commented 10 months ago

Palloxin: If it can help i had a similar problem on another app with the cursor position doing weird stuff and it happened only on miui

I can still reproduce in Firefox 121 Mobile & uBO 1.54 all the issues OP reported, in two different phones & different versions of Android, one with MIUI (Xiaomi Redmi Note Series) and the other without (Samsung Galaxy S Series), which means the issue is not specific only to MIUI, and Samsung keyboard is broken as well.

All the issues repored here cause managing My Filters in uBO Mobile be very cumbersome.

Also I'm aware that the issues are caused by CodeMirror rather than uBO: https://github.com/uBlockOrigin/uBlock-issues/issues/1716#issuecomment-917423757 + https://github.com/uBlockOrigin/uBlock-issues/issues/2805#issuecomment-1708871920, but if the issues will be fixed in CodeMirror, uBO will need to switch to the new version of CodeMirror.