uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
951 stars 82 forks source link

Extension description should be updated #2441

Open User6751 opened 1 year ago

User6751 commented 1 year ago

Prerequisites

I tried to reproduce the issue when...

Description

uBlock Origin store description include outdated information.

A specific URL where the issue occurs.

https://addons.mozilla.org/zh-TW/firefox/addon/ublock-origin/

Steps to Reproduce

click the extension stores link https://addons.opera.com/zh-tw/extensions/details/ublock/ https://microsoftedge.microsoft.com/addons/detail/ublock-origin/odfafepnkmbhccpbejgmiehpchacaeak https://chrome.google.com/webstore/detail/ublock-origin/cjpalhdlnbpafiamejdnhcphjbkeiagm Screenshot_20230104-141637_Chrome 20230104_141742 20230104_141731 Screenshot_20230104-141719_Chrome

Expected behavior

Filterlists that do not exists in uBo should be removed from description.

Actual behavior

description included some list do not exist in uBlock Origin : hpHosts’s Ad and tracking servers,MVPS HOSTS,Spam404, Malware domains,Long-lived malware domains,Malware Domains List,Fanboy’s Enhanced Tracking List

uBO version

uBlock Origin 1.46.0

Browser name and version

Chrome 108.0.5359.128

Operating System and version

Android 10

gothic-bum commented 1 year ago

See: https://github.com/uBlockOrigin/uBlock-issues/issues/971#issuecomment-657038195

gwarser commented 1 year ago

So it's fixed on Crowdin? Only need to be updated in web stores?

ghost commented 1 year ago

I updated the english web store description file (description-en.txt) recently in https://github.com/gorhill/uBlock/pull/3873 to modernize it, update URLs, update filter list names, remove outdated references and information, etc.

I saw the comment by @gorhill in regards to Crowdin and how it handles these things, and I understand his reluctance to proceed with updating the web store descriptions.

If @gorhill is willing to do something like a one-time massive update push to all the web stores to update the descriptions, we could use my commit (https://github.com/gorhill/uBlock/pull/3873) as a starting point. I would be happy to create another PR to update the description file even more if anything is missing or if further enhancements/refinements need to occur. All I would need from @gorhill is a final master copy of what the file/description needs to contain or just a list of changes/modifications he would like to make to be in the final master copy.

gorhill commented 1 year ago

Some people have argued the description shouldn't say "uBlock Origin (uBO) is NOT an 'ad blocker'" as this may discourage some people looking to install an "ad blocker" from installing it, but I disagree this, as I want to make it clear that the overarching goal is not to "block ads", but to block content for the purpose of privacy/security (which is undermined by ads).

The way I see it is that nobody complains that NoScript causes ads to be blocked and experts would usually agree that NoScript protects users (though at the cost of breaking sites). So I want the same stance toward uBO to avoid the argument that "blocking ads is mean", it's meant to work toward the same goals as other well known security/privacy tools, but without breaking sites (by default).

So maybe the sentence could be reworked as follow:

Though uBlock Origin (uBO) blocks ads by default, it is NOT an "ad blocker" ...

Or maybe not worth to change. Aside that, I would be ready to upload to crowdin and start to update the description in the Chrome Web Store.

vlaszlo commented 1 year ago

How about "uBlock Origin (uBO) is NOT only an 'ad blocker'"?

gorhill commented 1 year ago

Not fond of that formula as it implies at the basis it's an ad blocker, but it can do more. That's not uBO, that better describes the other actual "ad blockers" such as ABP/AdBlock/etc.

vlaszlo commented 1 year ago

That's true. In combination with "it's a wide-spectrum content blocker" it does transport the point, but weaker, not as clear and accentuated as your formulation above.

ghost commented 1 year ago

@gorhill,

What do you think of the following (Basically, just get rid of the mention of "NOT an "ad blocker" altogether.)?

uBlock Origin (uBO) is a wide-spectrum content blocker with CPU and memory efficiency as primary features.


Before I get a bunch of frown emotes or thumbs down, just to be clear, personally, I am 1,000,000% fine with the way it is now (No modification). I am literally just spitballing (Definition 3) ideas out there.

But, by all means instead of just reacting negatively to any ideas through emoticons, please be part of the conversation and share your ideas.

gorhill commented 1 year ago

Removing all instances of "ad blocker" could cause uBO to no longer be returned when someone search for "ad blocker" even though it works better than actual top ad blockers in a wide variety of cases. I think just prepending the current text with the following would be fine.

Though uBlock Origin (uBO) blocks all ads by default, ...

I am just not sure if there is a better way to formulate in proper English.

ghost commented 1 year ago

@gorhill,

Though uBlock Origin (uBO) blocks all ads by default, it is a wide-spectrum content blocker with CPU and memory efficiency as primary features.

This actually works just fine. I like this phrasing even better now.

Would you like me to submit a new PR real quick?

gorhill commented 1 year ago

We really need to keep "... by default, it is NOT an 'ad blocker', it is a wide-spectrum ..." -- de-emphasizing "not" would be fine though.

ghost commented 1 year ago

Though uBlock Origin (uBO) blocks all ads by default, it is not an "ad blocker." It is a wide-spectrum content blocker with CPU and memory efficiency as primary features.

@gorhill, what about dropping the "quotation marks" around ad blocker? The way the sentences read now, I don't believe the "quatation marks" are needed.

gorhill commented 1 year ago

I really want it like this at this point -- I feel the quotes are needed as this refers to how actual ad blockers call themselves:

Though uBlock Origin (uBO) blocks all ads by default, it is not an "ad blocker," it is a wide-spectrum content blocker with CPU and memory efficiency as primary features.

I will make the change and we can continue pondering about it from this point.

ghost commented 1 year ago

Ok, I am fine with that.

Just one small possible change?

Use this version?

Though uBlock Origin (uBO) blocks all ads by default, it is not an "ad blocker." It is a wide-spectrum content blocker with CPU and memory efficiency as primary features.

This makes it 2 sentences and is more grammatically correct.

gorhill commented 1 year ago

If it's more grammatically correct then it should be corrected.

ghost commented 1 year ago

#3883

Thorin-Oakenpants commented 1 year ago

sorry for the noise ... and I know you merged .. but honestly, I think you could/should flip this on it's head and lead with the purpose not the exception

gorhill: https://github.com/uBlockOrigin/uBlock-issues/issues/2441#issuecomment-1374044515

Though uBlock Origin (uBO) blocks all ads by default, it is not an "ad blocker," it is a wide-spectrum content blocker with CPU and memory efficiency as primary features.

modified (rough idea)

uBlock Origin (uBO) is a CPU and memory efficient wide-spectrum content blocker - it is not just an "ad blocker".

short, sweet, no need to mention ads blocked by default because that is implied by the word just. IDK, up to you. If you wanted to emphasize the purpose more, you could add the work primarily .. i.e ... is primarily a CPU ...

/my-2-cents

gorhill commented 1 year ago

Works for me, let's see what others think.

Thorin-Oakenpants commented 1 year ago

^ this also solves the issue of saying that it is NOT an "ad blocker" which technically isn't true as for all intents and purposes, and especially to the layman, it does "ad blocking" - not arguing against gorhill's reasoning for wanting to emphasize that this is a subset of features, not it's main purpose by design, but the phrasing is "unfortunate" :)

ghost commented 1 year ago

I think @Thorin-Oakenpants nailed it here with their suggestion. It makes the sentence more concise and still says what @gorhill wants. I made a further refinement to make it even shorter.

I think the new final sentence should be this:

uBlock Origin (uBO) is a CPU and memory-efficient wide-spectrum content blocker, not just an "ad blocker."

u-RraaLL commented 1 year ago

Personally, I liked @Thorin-Oakenpants's verse better.

But I thought I'd also give it a shot: uBlock Origin (uBO) is a CPU and memory-efficient wide-spectrum content blocker. By default, it also functions as an install-and-forget type of "ad blocker." Or: uBlock Origin (uBO) is a CPU and memory-efficient wide-spectrum content blocker. By default, it is also meant to function as an install-and-forget type of "ad blocker."

gorhill commented 1 year ago

By default it blocks more than just ads though.

We could merge with the second sentence:

uBlock Origin (uBO) is a CPU and memory efficient wide-spectrum content blocker which blocks ads, trackers, coin miners, popups, etc. through the following lists of filters, enabled by default:

u-RraaLL commented 1 year ago

By default it blocks more than just ads though.

I know, thus the use of "also" ;)

Merging with the 2nd line is good too.

But I'd probably change it to something like:

uBlock Origin (uBO) is a CPU and memory efficient wide-spectrum content blocker which blocks ads, trackers, coin miners, popups, etc., by default.

It does so through the following lists of filters:

ghost commented 1 year ago

@gorhill,

I like your idea even better. Here is a grammatically correct version of it with a few minor changes I made:

uBlock Origin (uBO) is a CPU and memory-efficient wide-spectrum content blocker that blocks ads, trackers, coin miners, popups, etc., using the following list of filters, enabled by default:

MasterKia commented 1 year ago

Didn't the era of coin miners end a few years ago? The resource-abuse list has only 77 entries.

uBlock Origin (uBO) is a CPU and memory efficient wide-spectrum content blocker which can block ads, trackers, coin miners, popups and other annoyances through the following lists of filters, enabled by default:

"Can" emphasizes that this content blocker is capable of blocking such things, if you want it to (by enabling such and such filterlists).

gorhill commented 1 year ago

We have to spell out what it does out of the box, see https://twitter.com/gorhill/status/1326641499954679809.

It's not a "can" case, we are explaining what it does by default following installation.

gorhill commented 1 year ago

Actually we could also mention it blocks obnoxious (or whatever adjective works best) anti-blockers by default.

ghost commented 1 year ago

Good Morning @gorhill,

Here is an updated and grammatically correct version of the sentence I propose that includes your new idea above:

uBlock Origin (uBO) is a CPU and memory-efficient wide-spectrum content blocker that blocks ads, trackers, coin miners, popups, annoying anti-blockers, etc., using the following list of filters, enabled by default:

MasterKia commented 1 year ago

It's not a "can" case, we are explaining what it does by default following installation.

What I initially had in mind was (which I forgot to mention):

uBlock Origin (uBO) is a CPU and memory efficient wide-spectrum content blocker which can block ads, trackers, coin miners, popups and cookie prompts through the following lists of filters, enabled by default:

EasyList Cookies is disabled by default, hence the "can block [...]".

Cookie prompts can be seen as invasive and unwanted by many users; thus stating that uBO -a content blocker- is able to block those invasive contents makes sense.

gorhill commented 1 year ago

That's mentioned in the immediately following section:

More lists are available for you to select if you wish:

  • EasyList Cookie List ...

Maybe we could rework that following section with typical list groups often enabled with a short description of what the lists in those groups do:

  • Privacy -- to remove URL tracking parameters
  • Annoyances -- to remove cookie warnings, signup overlays, social media widgets, ...
  • Regions -- to enable per-country filter lists
  • Custom -- bring your own filter lists
MasterKia commented 1 year ago

Speaking of "typical list groups", I think it's a good time to share what @Yuki2718 had sent before in the internal discussions, I think it's a good idea to implement inside uBO itself:

Consider splitting AdGuard Annoyances into sublists: This is a blog post about that: https://adguard.com/en/blog/new-annoyance-filters.html Annoyances = Cookie Notices filter + Popups filter + Mobile App Banners filter + Widgets filter + Other Annoyances filter To the philosophy of uBO - you decide what enters your browser - it'll be beneficial to split built-in AdGuard Annoyances into 5 sublists and let user to choose what to block and what not. Those who already subscribe AdGuard Annoyances can be addressed by moving into Custom as always.

Something in the form of:

krystian3w commented 1 year ago

Something in the form of:

One big file can be disabled in future: https://github.com/AdguardTeam/FiltersRegistry/issues/718

gwarser commented 1 year ago

Will this be eventually uploaded to Crowdin?

See: https://www.reddit.com/r/uBlockOrigin/comments/11g06mw/i_see_a_p_in_the_ignore_generic_cosmetic_filters/jamk620/?context=3

Details ```` --------------------------------------------What I see on crowdin.com/translate/ublock------------------------------------------------ An efficient blocker: easy on memory and CPU footprint, and yet can load and enforce thousands more filters than other popular blockers out there. Illustrated overview of its efficiency: https://github.com/gorhill/uBlock/wiki/uBlock-vs.-ABP:-efficiency-compared Usage: The big power button in the pop-up is to permanently disable/enable uBlock for the current website. It applies to the current website only; it is not a global power button. *** Flexible, it's more than an "ad blocker": it can also read and create filters from hosts files. Out of the box, these lists of filters are loaded and enforced: - EasyList - Peter Lowe’s Ad server list - EasyPrivacy - Malware domains More lists are available for you to select if you wish: - Fanboy’s Enhanced Tracking List - Dan Pollock’s hosts file - hpHosts’s Ad and tracking servers - MVPS HOSTS - Spam404 - And many others Of course, the more filters enabled, the higher the memory footprint. Yet, even after adding Fanboy's two extra lists, hpHosts’s Ad and tracking servers, uBlock still has a lower memory footprint than other very popular blockers out there. Also, be aware that selecting some of these extra lists may lead to higher likelihood of website breakage -- especially those lists which are normally used as hosts file. *** Without the preset lists of filters, this extension is nothing. So if ever you really do want to contribute something, think about the people working hard to maintain the filter lists you are using, which were made available to use by all for free. *** Free. Open source with public licence (GPLv3) For users, by users. Contributors @ Github: https://github.com/gorhill/uBlock/graphs/contributors Contributors @ Crowdin: https://crowdin.net/project/ublock *** It's quite an early version, keep this in mind when you review. Project change log: https://github.com/gorhill/uBlock/releases ------------------------------------------------------What I see in the chrome store-------------------------------------------------- Finally, an efficient blocker. Easy on CPU and memory. IMPORTANT: uBlock Origin is completely unrelated to the site "ublock.org". uBlock Origin is not an "ad blocker", it's a wide-spectrum content blocker with CPU and memory efficiency as a primary feature. *** Out of the box, these lists of filters are loaded and enforced: - uBlock Origin filter lists - EasyList (ads) - EasyPrivacy (tracking) - Peter Lowe’s Ad server list (ads and tracking) - Online Malicious URL Blocklist More lists are available for you to select if you wish: - Annoyances (cookie warnings, overlays, etc.) - hosts-based lists - And many others Additionally, you can point-and-click to block JavaScript locally or globally, create your own global or local rules to override entries from filter lists, and many more advanced features. *** Free. Open source with public license (GPLv3) For users by users. If ever you really do want to contribute something, think about the people working hard to maintain the filter lists you are using, which were made available to use by all for free. *** Documentation: https://github.com/gorhill/uBlock#ublock-origin Project change log: https://github.com/gorhill/uBlock/releases Contributors @ Github: https://github.com/gorhill/uBlock/graphs/contributors Contributors @ Crowdin: https://crowdin.net/project/ublock ```
Korb commented 1 year ago

The description contains outdated information about finding the issue tracker ("Contributors @ GitHub", https://github.com/gorhill/uBlock/issues instead of https://github.com/uBlockOrigin/uBlock-issues/issues).