Anti-redirect scriptlet for vk.com (href-sanitizer)

uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin

https://github.com/gorhill/uBlock

935 stars 79 forks source link

Anti-redirect scriptlet for vk.com (href-sanitizer) #2531

Closed dimisa-RUAdList closed 1 year ago

dimisa-RUAdList commented 1 year ago

Prerequisites

[X] I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
[X] The issue is not present after disabling uBO in the browser.
[X] I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

[X] uBO is the only extension.
[X] using a new, unmodified browser profile.

Description

The site vk.com is one of the most visited Russian sites. All external links on this site are done through a redirect.

There is an idea to create a scriptlet with a name like "anti-redirect" based on this script: https://greasyfork.org/en/scripts/395977-vk-com-del-redir/code

A specific URL where the issue occurs.

https://vk.com/amedia.online

Steps to Reproduce

undefined

Expected behavior

undefined

Actual behavior

undefined

Configuration

uBlock Origin development build 1.47.5b2

Yuki2718 commented 5 months ago

The rule stopped working.

stephenhawk8054 commented 5 months ago

@Yuki2718 Currently I'm testing on just Firefox. Can you check again?

Yuki2718 commented 5 months ago

I was wrong, the rule is still working for usual links. It doesn't work only for card links with images like the one in https://twitter.com/imabarizine/status/1784740979209355751.

stephenhawk8054 commented 5 months ago

Yeah, the card is quite hard, I don't know how to address it

stephenhawk8054 commented 5 months ago

Hmm... From this link: https://help.twitter.com/en/using-x/url-shortener , looks like t.co is also used to check malicious domains, so not sure if we should address this issue or not.

What do you guys think? Or maybe we can move it to annoyance list?

Yuki2718 commented 5 months ago

Yeah, maybe safer to move to annoyance.

gwarser commented 5 months ago

Ordinary links cannot be checked for malware?

stephenhawk8054 commented 5 months ago

Ordinary links cannot be checked for malware?

Hmm... By which method?

gwarser commented 5 months ago

I think this is just Twitter's excuse to track clicks.

Yuki2718 commented 5 months ago

Yeah, I haven't ever warned when clicking bad links for badware. But who knows.

Yuki2718 commented 4 months ago

Found an example Twitter/X warns if via t.co: https://x.com/2cheromatome/status/1508499176874815492 Not actually a dangerous link though. I'll move the rule to Annoyances.

Yuki2718 commented 3 weeks ago

Links in threads.net on mobile redirect to l.threads.net when you loaded any pages, but it'll be self-fixed to actual links if you wait a minute so not sure if this should be addressed.

stephenhawk8054 commented 3 weeks ago

I think it's fine to address