uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
879 stars 76 forks source link

firefox nightly: weird grey top bar & reload button randomly added to uBO's extension UI #3284

Open ComfortableMilk4454 opened 1 week ago

ComfortableMilk4454 commented 1 week ago

Prerequisites

I tried to reproduce the issue when...

Description

firefox nightly: weird grey top bar that disappears after a few seconds and when that happens reload button gets randomly added to uBO's extension UI (see screen recording): THIS ONLY HAPPENS UPON LAUNCHING NIGHTLY & CLICKING ON UBO'S EXTENSION ICON, NOT WHEN NAVIGATING TO A NEW TAB WITH NIGHTLY ALREADY RUNNING & CLICKING ON UBO'S EXTENSION ICON. fyi if you saw i have adguard running on my mac dw i made sure to turn it off for firefox, so this issue is not caused by "stacking" adblockers

A specific URL where the issue occurs.

new nightly tab

Steps to Reproduce

  1. click on uBO's icon

Expected behavior

no bar at the top & no refresh button appearing

Actual behavior

bar at the top & refresh button appears

uBO version

1.58.0

Browser name and version

Firefox Nightly 129.0a1 (2024-06-28) (64-bit) & all versions of nightly over the past month or so

Operating System and version

macOS 14.5 (23F79)

gorhill commented 1 week ago

That grey bar is where the hostname of the current site appears normally, and if it's not filled with the hostname at browser launch it's simply because uBO's background process has not yet been fully initialized. It gets filled in once the background process is initialized and ready to answer requests from the popup panel.

ComfortableMilk4454 commented 1 week ago

i see. so this is a nightly issue then, because this doesn't happen on firefox release, right? thanks for explaining.

gorhill commented 1 week ago

Not necessarily a Nightly issue. There is a lot of thing which can prevent uBO's background process from answering in a timely manner to requests from its auxiliary page. In Firefox all extensions execute in the same process, so even another extension hogging the webextensions process could affect responsiveness in other extensions. It could be a delay originating from Firefox itself, for example https://bugzilla.mozilla.org/show_bug.cgi?id=1899015.

Profiling at browser launch would maybe help identify the sequence of events. In any case, there is no malfunction, it's just that there is a delay between the popup requesting information from the background process, and the background process answering that delay.

I could add a non-breakable whitespace character as placeholder to ensure the vertical size of the grey bar does not change.

garry-ut99 commented 1 week ago

Not only a Firefox Nightly issue, as the same occurs also on Firefox Release on a fresh browser profile. Currently doesn't occur in Chromium and Edge, so it's related to Firefox. However it was happening also in Chromium and Edge in the past, but not anymore, as still can be reproduced in old browsers like Chromium 109 or Edge 109.

this only happens upon launching nightly & clicking on ubo's extension icon

Or by turning off & on uBlock in browser extension pane (Firefox). In old Chromium 109 or Edge 109, I still need to use "restarting browser" method to reproduce. Method might depend on how fast is CPU, as different users have different CPUs.


Also similiar to (or even might be related or duplicate, as big power button is white for a while in the both issues):