uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
945 stars 81 forks source link

Some rules may break websites that use socks proxy in Firefox #3379

Closed ghcsd closed 1 month ago

ghcsd commented 1 month ago

Prerequisites

I tried to reproduce the issue when...

Description

Some rules may break websites that use socks proxy in Firefox

A specific URL where the issue occurs.

https://github.com/gorhill/uBlock

Steps to Reproduce

  1. Enable Socks5 proxy in Firefox.

    Screenshots
  2. Ensure to enable Uncloak canonical names in uBlock.

  3. Ensure that uBlock filters - Privacy is enabled in the uBlock Filter lists, or add the following rules to My filters. *$all,ipaddress=0.0.0.0,domain=~0.0.0.0|~127.0.0.1|~[::1]|~[::]|~local|~localhost

  4. load https://github.com/gorhill/uBlock.

Screenshots

Possible related bug:

Developer tools always shows 0.0.0.0 as remote address when proxy is used https://bugzilla.mozilla.org/show_bug.cgi?id=1445279


Sorry for my bad English.

Expected behavior

...

Actual behavior

The page is not fully loaded

uBO version

uBlock Origin 1.59.1.22

Browser name and version

Firefox Nightly 132.0a1 (2024-09-16)

Operating System and version

Windows 10

gorhill commented 1 month ago

Enable Socks5 proxy in Firefox

I can reproduce when using Tor browser as proxy:

Especially, Proxy DNS when using SOCKS v5 must be check -- the issue is not reproducible without that setting.

Unfortunately, the bugzilla issue related to this is stale, so no workaround possible.

For now uBO will have to discard the browser-framework provided IP address when it's 0.0.0.0.

HyperSoop commented 1 month ago

Same here, using uBO in LibreWolf on Linux with a Tor SOCKS5 proxy, the uBlock filters - Privacy list breaks pretty much all websites catastrophically

stephenhawk8054 commented 1 month ago

For now uBO will have to discard the browser-framework provided IP address when it's 0.0.0.0.

So, is it the dns.resolve() or onHeadersReceived()?

gorhill commented 1 month ago

So, is it the dns.resolve() or onHeadersReceived()?

It's browser-provided ip address to webRequest listeners, so onHeadersReceived().

1.59.1rc1 contains a tentative fix, to be confirmed by those suffering the issue.

MasterKia commented 1 month ago

It's fixed for me.

HyperSoop commented 1 month ago

Works for me now too