Cannot type double quotes in My Filters editor using Option + F

anohren commented 6 days ago

Prerequisites

[X] I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
[X] This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
[X] This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
[X] I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
[X] The issue is not present after disabling uBO in the browser.
[X] I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

[X] uBO is the only extension.
[X] uBO uses default lists and settings.
[X] using a new, unmodified browser profile.

Description

Thank you for a fantastic project 👌 and saving my attention from unrelenting attack.

I cannot type double quotes in My Filters editor using my usual keyboard layout (Svorak A5) using Option + F. Cursor instead moves to next word. It's very difficult to use text editors that override typing.

A specific URL where the issue occurs.

moz-extension://44f09695-93ee-ad48-9694-d471cdae835c/dashboard.html#1p-filters.html

Steps to Reproduce

Install Svorak A5 for macOS and switch to that layout
Go to My Filters settings pane
Try to type " using Option + F

Expected behavior

The character I type appears in the text editor

Actual behavior

Caret moves to next word ending

uBO version

1.60.0

Browser name and version

Firefox 115.16.1esr

Operating System and version

macOS 10.14.6 Mojave

gwarser commented 6 days ago

Does it work on this page: https://codemirror.net/5/ ?

garry-ut99 commented 5 days ago

anohren: Cursor instead moves to next word. anohren: Caret moves to next word ending

Option key is known also as Alt key, and as per documentation:

https://github.com/gorhill/uBlock/wiki/Dashboard:-My-filters ==> CodeMirror's own documentation : goWordRight: Move the cursor to the end of the next word. Alt-F (Mac)

Related issue:

https://github.com/codemirror/codemirror5/issues/4066

anohren commented 5 days ago

@garry-ut99 Thanks for the reference.

I did visit the wiki page you link to, and I did visit the first link to https://codemirror.net/index.html. From there I couldn't find a user manual on their Documentation page, after which I did not follow any more links to CodeMirror's site.

I probably wouldn't have missed it if the first link to them wasn't there in the wiki 🙂

Edit: also, the second link just appears to link to contents that you have already published on the wiki page, hence the "no need to visit that link" reaction.

Anyway, it's still a problem, but what I can gather from the linked issue it can only be fixed by clients, by implementing e.g. a "disable keyboard shortcuts" button?

I'll leave it to you to decide whether it's worth it to support arbitrary (programming) keyboard layouts. I personally don't do a lot of typing in uBlock, but let's just say I avoid Google drive/docs 😅 They've built the office equivalent of a game without configurable controls.

gorhill commented 5 days ago

I did visit the first link to https://codemirror.net/index.html. From there I couldn't find a user manual

You were asked whether you have the same issue with the embedded editor at https://codemirror.net/5/. If so, then it means CodeMirror 5 does not support custom keyboard layouts.

anohren commented 5 days ago

That will have to wait until I'm at my computer I'm afraid.

garry-ut99 commented 5 days ago

anohren: I did visit the wiki page you link to, and I did visit the first link to codemirror.net/index.html. From there I couldn't find a user manual on their Documentation page, after which I did not follow any more links to CodeMirror's site.

anohren: I probably wouldn't have missed it if the first link to them wasn't there in the wiki

Just try to read documentations more carefully and to not shift blame to maintentainers of CodeMirror's site or uBO Wiki's site just because you failed to find a link to documentation on the both sites, it seems it is rather you who have problems with searching for informations.

anohren: Edit: also, the second link just appears to link to contents that you have already published on the wiki page, hence the "no need to visit that link" reaction.

It wasn't me who published the second link & shortcuts table in Wiki, someone else did, see commits history: https://github.com/gorhill/uBlock/wiki/Dashboard:-My-filters/_history, but this is another thing that you have a problem with finding.

And as for my link to CodeMirror's shortcuts site in my comment: it was intentionally, because not all shortcuts are mentioned on uBO's Wiki page, for example Alt-F / Options-F is not mentioned, only Ctrl-F and Cmd-F, maybe the person who put the second link in Wiki, did it for the same reason, I dunno.

anohren: Edit: I'll leave it to you to decide

I'm a volunteer, not uBO creator, but this is another thing that you have a problem with finding.

(Nothing personal, just that your comment was full of blind conclusions and blaming, hence I'm simply just clearing things out).

anohren commented 5 days ago

@garry-ut99. I thanked you for the link; I described -- objectively -- the chain of events that led me to miss the relevant documentation, so that project members can make an informed decision to change it if they want; despite this I also used smilies to soften any perceived blow to the ego when suggesting a possible solution -- you start telling me I'm "blaming" (who exactly did I blame?) and making a list of my "problems". That's nice.

I've not tried to blame anyone.

Just try to read documentations more carefully

it seems it is rather you who have problems with searching for informations.

I skimmed a lot of documentation before posting. I did not mainly come here to go out of my way to search for possibly non-existent information, but to report a problem -- I followed the bug template as quickly as reasonably possible. Who are you to judge how much time and energy I put into it, especially after I described exactly how I did my best?

If you dont think that the Issues section is a place for constructive feedback that project maintainers can use to decide whether to act on, at their own discretion, then maybe I'm not the only one who needs his "problems" listed.

It wasn't me who published the second link & shortcuts table in Wiki

No one has suggested that you're the autor of a wiki page. But sure, I could have used the collective term "we" (me and the project) instead of "you" (by which I meant "the project"). I was unclear, and I apologize if you felt personally targeted.

anohren: Edit: I'll leave it to you to decide

I'm a volunteer, not uBO creator, but this is another thing that you have a problem with finding.

"You" as in plural -- "whover reads and feels part of the project". Nothing I wrote was meant to revolve around you personally.

anohren commented 5 days ago

Does it work on this page: https://codemirror.net/5/ ?

Typing double quotes seems to work fine there.

gorhill commented 5 days ago

In that case, I will let whoever can reproduce to investigate and suggest a fix.

garry-ut99 commented 5 days ago

anohren : you start telling me I'm "blaming" (who exactly did I blame?)

anohren : I described -- objectively -- the chain of events that led me to miss the relevant documentation, so that project members can make an informed decision to change it if they want (...)

In a way which suggested in the advance that it wasn't your fault and that it were maintainers of CodeMirror's and uBO Wiki's responsible for your mistakes, which is a sort of blaming, isn't it.

anohren : despite this I also used smilies to soften any perceived blow to the ego when suggesting a possible solution

Good, but this doesn't change a fact that you shifted responsibility for your own mistakes to others.

and making a list of my "problems".

Because you got ones.

anohren : That's nice.

I was as much "nice" as you were, what's the problem then, try to look in the mirror and don't reverse sequence of facts.

anohren : I've not tried to blame anyone.

But you did, try better next time.

anohren : I skimmed a lot of documentation before posting. I did not mainly come here to go out of my way to search for possibly non-existent information, but to report a problem -- I followed the bug template as quickly as reasonably possible. Who are you to judge how much time and energy I put into it, especially after I described exactly how I did my best?

I didn't judge how much time you spent, nor how much documentation you read, I only stated facts that you missed informations / links and that you should look for fault on your side.

anohren : If you don't think that the Issues section is a place for constructive feedback that project maintainers can use to decide whether to act on, at their own discretion, then maybe I'm not the only one who needs his "problems" listed.

Shifting responsibility of your own mistakes to others is neither "nice" nor a "constructive feedback". Again I don't see anything wrong with CodeMirror's site documentation and uBO "My filters" page documentation, all informations are there.

anohren : No one has suggested that you're the autor of a wiki page.

You did.

anohren : But sure, I could have used the collective term "we" (me and the project) instead of "you" (by which I meant "the project"). I was unclear, and I apologize if you felt personally targeted.

But you used "you", I stick to what is written, instead of guessing X different contextes one had in his mind. Yes, try to be more clear next time

anohren : "You" as in plural -- "whover reads and feels part of the project". Nothing I wrote was meant to revolve around you personally.

Another example of your unclearness.

Now there is a proof that not only you got problems with reading, but also with writing.

Besides, your problems with reading and writing caused already too much of off-topic in the current thread (to which I unfortunately had to reply to save myself from the strange accusations you created). I think you should stop at this point, no point to continue this, just let it go, no point in arguing for the sake of arguing.

gwarser commented 5 days ago

Layout can be installed on other systems https://svorak.ahall.se/download.php

Layout does not work for me on Manjaro, and on Windows 11 correctly inserts " with Alt - Alt+Y.

uBO 1.60.0, Firefox 132.0.1.

anohren commented 5 days ago

Here's the part of my allegedly problematic comment where I'm "blaming" and "accusing":

@garry-ut99 Thanks for the reference.

I did visit the wiki page you link to, and I did visit the first link to https://codemirror.net/index.html. From there I couldn't find a user manual on their Documentation page, after which I did not follow any more links to CodeMirror's site.

I probably wouldn't have missed it if the first link to them wasn't there in the wiki 🙂

Edit: also, the second link just appears to link to contents that you have already published on the wiki page, hence the "no need to visit that link" reaction.

Demonstration that I did in fact visit the docs as instructed in the issue template, and didn't skip it.
A friendly suggestion if anyone decides they want to minimize chances of this mistake in the future.
I ambiguously use "you" while trying to describe my thought process while making the mistake.

This seems to have warranted some hostility.

In a way which suggested in the advance that it wasn't your fault and that it were maintainers of CodeMirror's and uBO Wiki's responsible for your mistakes, which is a sort of blaming, isn't it.

If you have no interest in design, then I can see why a cognitive walkthrough of what I was thinking -- when reading an article and coming to the wrong conclusion -- seems like information that is of no use. Nevertheless, if one were inclined to design away the mistake I made when reading, then I've provided the information of how it was made, ready to be used. I wouldn't ask you personally to design this away though, nor expect you to be interested in it.

Good, but this doesn't change a fact that you shifted responsibility for your own mistakes to others.

I described why I dismissed the second link, as well as why I dismissed the external Documentation page. So far, you're the one who's insisting that there has to be blame: You want to blame me and only me, I get it. You also seem intent on underlining the fact that I made a mistake -- yes. So? Easy mistake to make, as described. I'm simply accepting that "it happened" and mentioning "here's how it can be designed away".

I didn't judge how much time you spent, nor how much documentation you read, I only stated facts that you missed informations / links and that you should look for fault on your side.

Why should I look for fault on my side, when it was pointed out in your first message with the link you quoted? I made a simple mistake -- never denied it. I moved on immediately to how that could be prevented in the future, if one so wishes. I think that's constructive. You linger on the fact that I missed a link -- yes, no one will dispute you on that.

Shifting responsibility of your own mistakes to others is neither "nice" nor a "constructive feedback".

Describing how I made the mistake is simply fact -- it happened. I was neither trying to be "nice" nor its opposite. I know that I was never trying to be unfriendly to anyone. If you (in the plural sense) are the kind of project that want to design away such mistakes as was described (none of my business whether a project is interested in that or not) then, to the contrary, yes, it is constructive feedback which one can use if one so chooses.

Again I don't see anything wrong with CodeMirror's site documentation and uBO "My filters" page documentation, all informations are there.

If you see nothing wrong, you're free to simply not do anything about it -- I don't see why any hostility is necessary. I've described how I couldn't find the relevant manual on CodeMirror's Documentation page, and why that led to me dismissing their site for further research. If you're not a designer then that might be uninteresting to you; if you're a designer, maybe it'll be useful (I use "you" in a general sense here). Not a reason to continue to ascribe it to malicious intent, like blame or accusation, where none exists.

If anyone from CodeMirror was here, yes, I'd suggest that the page with the keyboard shortcuts could be easier to find, because I didn't and because this is a place for giving feedback.

and making a list of my "problems".

Because you got ones.

It's a great way to make it "nothing personal", as you describe it.

But you used "you", I stick to what is written, instead of guessing X different contextes one had in his mind.

I used "you" in the plural sense, and you interpreted it another way, so what was written was clearly ambiguous. I apologize for the ambiguity. You can stick with the antagonistic interpretation if you must.

strange accusations you created).

Once again, I've not tried to accuse anyone in particular of any defect in the software or documentation. As you said, I neither know (nor care) who wrote the wiki article. I don't think there's any need for getting worked up over the suggestion that the mistake of skipping a link can be designed away. Those who are interested in designing away the mistake are free to do so, and those who aren't interested don't have to do anything.

I think you should stop

no point to continue this

just let it go

no point in arguing for the sake of arguing

It sounds as though you want to stop.

gorhill commented 4 days ago

Layout does not work for me on Manjaro

Linux Mint in a virtual machine, I enabled "Swedish (Dvorak A5)", which causes my Y key to become F, with Right Alt-Y for ", and it worked correctly on my side, I could enter double quotes. This will have to be investigated by someone else who can reproduce with a Mac OS.

garry-ut99 commented 3 days ago

anohren:

I described why I dismissed the second link, as well as why I dismissed the external Documentation page. I've described how I couldn't find the relevant manual on CodeMirror's Documentation page, and why that led to me dismissing their site for further research. Describing how I made the mistake is simply fact -- it happened. I don't think there's any need for getting worked up over the suggestion that the mistake of skipping a link can be designed away. Those who are interested in designing away the mistake are free to do so, and those who aren't interested don't have to do anything.

The reasons you provided are baseless, you are looking for problems with documentation where are none, like I already said: all informations and links are on their place, if you overlooked them, this is not documentation's fault, hence your proposals to improve documentation don't make much sense.

anohren: So far, you're the one who's insisting that there has to be blame: You want to blame me and only me, I get it.

Logically if this is not documentation's fault, then whose fault is it, if not yours? This comes by itself, from logical implication, and not because I want to blame you.

anohren: You also seem intent on underlining the fact that I made a mistake -- yes. So? Easy mistake to make, as described. I'm simply accepting that "it happened" and mentioning "here's how it can be designed away". I made a simple mistake -- never denied it. You linger on the fact that I missed a link -- yes, no one will dispute you on that.

You were the one who was suggesting that this might be a documentation's fault, and you admited and emphasized your own mistakes only now, after I pushed you back by argumentation, and not because you wanted to do it by yourself, don't play nice now.

anohren: If you see nothing wrong, you're free to simply not do anything about it

I prefer to take action and to not allow random users to jump in and baselessly accuse documentation.

anohren: I don't see why any hostility is necessary. Not a reason to continue to ascribe it to malicious intent, like blame or accusation, where none exists.

No "hostility". I wasn't reffering to your "intents", I was reffering to your comments, if what is in your comments is misworded and doesn't stick to your intents, then this is not my problerm, I replied to what is written, not to what is in your mind, try to word your intentions better next time.

anohren: It's a great way to make it "nothing personal", as you describe it.

It was not aimed at you personally, just a technical statement of facts that I noticed and proved, using argumentation, if you don't agree, you can provide counter-argumentation, unless quoting my sentences and sticking labels to it, is due to a lack of argumentation on your side.

anohren: I used "you" in the plural sense, and you interpreted it another way, so what was written was clearly ambiguous. I apologize for the ambiguity. You can stick with the antagonistic interpretation if you must.

Again, I replied to what is written, try to word your intentions better next time. I don't need to stick to antagonistic interpretation now, but I had the right to do it before you cleared it out.

anohren: Once again, I've not tried to accuse anyone in particular of any defect in the software or documentation.

But you did, maybe unintentionally, but who cares, like I said, try to word your intentions better next time.

anohren: It sounds as though you want to stop.

Not due to a lack of argumentation on my side, but due to a wish of stopping unnecessary off-topic, but you're suggesting the former, don't you? Just like you were suggesting that your mistakes were caused by bad documentation, and now you're going to tell us again that your intents was different than your suggestions...

anohren: It sounds as though you want to stop.

It sounds as though you want to continue, enjoy then.

gorhill commented 3 days ago

@garry-ut99 Can you please stop escalating and de-escalate instead? As a volunteer here, there was no need for this comment in the first place, which is what started all these off-topic comments.

I expect volunteers here to help prevent threads descending into endless back and forth which are a waste of time for everybody and of no use to investigate/fix issues. This means to not pick on everything said by reporters that displeases you, and when this happens, just ignore by re-focusing on the issue at hand if you have more information to make resolution go forward.

garry-ut99 commented 3 days ago

gorhill: Can you please stop escalating and de-escalate instead?

So funny, do you work in circus? Can you please stop trolling or kidding? You must be kidding right? Are you blind or are you trolling on purpose? It was me who tried to de-escalate, and it was the guy who decided to continue escalation, see:

garry-ut99: Besides, your problems with reading and writing caused already too much of off-topic in the current thread (to which I unfortunately had to reply to save myself from the strange accusations you created). I think you should stop at this point, no point to continue this, just let it go, no point in arguing for the sake of arguing.

anohren: It sounds as though you want to stop.

garry-ut99: Not due to a lack of argumentation on my side, but due to a wish of stopping unnecessary off-topic

anohren: It sounds as though you want to stop.

garry-ut99: It sounds as though you want to continue, enjoy then.

gorhill: As a volunteer here, there was no need for https://github.com/uBlockOrigin/uBlock-issues/issues/3447#issuecomment-2466270440 in the first place, which is what started all these off-topic comments.

No, there was no need for https://github.com/uBlockOrigin/uBlock-issues/issues/3447#issuecomment-2466243162 in the first place, which is what started all these off-topic comments. Could you please stop reversing order of facts, and lecture the person who started?

gorhill: I expect volunteers here to help prevent threads descending into endless back and forth which are a waste of time for everybody and of no use to investigate/fix issues. This means to not pick on everything said by reporters that displeases you, and when this happens, just ignore by re-focusing on the issue at hand if you have more information to make resolution go forward.

I tried, but ignoring is not an universal solution to all problematic users, such users should be told clearly that they should not shift responsibility for their own mistakes.

By the way, you still lecture others like a hero but at the same time you don't let others lecture you (for example, in a thread where you were replying with attitude and poisoning the whole discussion?: https://github.com/garry-ut99/test/issues/1#issuecomment-2339473924. Disgusting, please go away and go troll elsewhere, you should be employed in a circus.

uBlockOrigin / uBlock-issues