search

uBlockOrigin / uBlock-issues

This is the community-maintained issue tracker for uBlock Origin
https://github.com/gorhill/uBlock
945 stars 81 forks source link

Web pages never load - Firefox Nightly, uBlock 1.18.4 #416

Closed sciguyryan closed 5 years ago

sciguyryan commented 5 years ago

Prerequisites

Description

Pages will not load in Firefox nightly (after 28/1/2019) with uBlock enabled. Pages will never load as soon as the addon is enabled. Disabling the addon instantly corrects the issue. This appears to function everywhere.

I had initially thought that Mozilla had somehow broken things, though after going through and disabling addons one at a time it appears to be a uBlock related issue.

The following can be found in the browser console: https://pastebin.com/GXbeDXnm

A specific URL where the issue occurs

https://google.com/

Steps to Reproduce

  1. Enabled uBlock.
  2. Refresh a web page. Pages will not load at all.
  3. Disable uBlock (or revert the browser to the 28/1 build).
  4. Web pages will once again load.

Expected behavior:

Pages should load correctly with the addon enabled.

Actual behavior:

Pages never finish loading with the addon enabled.

Your environment

uBlock-user commented 5 years ago

The following can be found in the browser console: https://pastebin.com/GXbeDXnm

Your nightly appears to be a broken build. I'm on 67.0a1 (2019-02-02) (64-bit) and cannot reproduce.

uBlock-user commented 5 years ago

Update to the latest nightly and try to reproduce.

sciguyryan commented 5 years ago

Update to the latest nightly and try to reproduce.

I did, hence step 3. I can resolve the issue by either downgrading nightly or by disabling uBlock.

uBlock-user commented 5 years ago

Firefox Nightly - 28/01/2019 build

but your browser version says January build, this is why i said update to the latest nightly build

I can resolve the issue by either downgrading nightly

So nightly is broken then, I'm updating to the latest Nightly. I will post if I can reproduce there.

uBlock-user commented 5 years ago

Updated to the latest Nightly on my device, web pages load normally as expected, but I do see one debug console error like you do.

sciguyryan commented 5 years ago

I'm going to give a clean profile a try and see if I can unpick what's going on then. It's particularly odd that it works perfectly if I revert back to the specific nightly build, though.

uBlock-user commented 5 years ago

Nightly is unstable and can be broken at any new build, so not a surprise.

gorhill commented 5 years ago

There is a wasm error in your console which make me think your indexedDB storage is corrupted. If you know were to find it, you could delete it manually and try restart uBO again.

LinuxOnTheDesktop commented 5 years ago

I have a somewhat similar problem; tell me whether I should open a new issue, please.

My problem is as follows and pertains to Firefox 65.0 (which is a 'release' build). When Firefox is open, and I click a link in Thunderbird, then, sometimes - depending on the URL? - and only when Ublock Origin is enabled for the page in question, the following occurs. Firefox will not load the page and indeed parts of the Firefox UI do not work. I have had this problem with URLs starting: https://bugzilla.mozilla.org/

EDIT: and I see this in the Firefox console:

Content Security Policy: Ignoring "'unsafe-inline'" within script-src or style-src: nonce-source or hash-source specified
Content Security Policy: The page's settings blocked the loading of a resource at inline ("script-src"). show_bug.cgi:1:1
Loading failed for the <script> with source “https://bugzilla.mozilla.org/static/v20190130.1/extensions/GoogleAnalytics/web/js/analytics.js”.
weaversam8 commented 5 years ago

I have also experienced this issue. Logged into my laptop today to find no web pages loading. I'm running Firefox Developer Edition, 66.0b6 build ID 20190207161357, update channel aurora, on Windows 10.

Disabling the add-on fixed the problem, and the problem persisted even after the add-on was uninstalled, reinstalled, and reset to default settings.

gorhill commented 5 years ago

Any errors reported at the browser console? (ctrl-shift-J)

Also, try with a new fresh profile.

weaversam8 commented 5 years ago

Tried both in a fresh profile and in my existing profile and the issue has entirely disappeared. Unable to reproduce all of a sudden :/

LinuxOnTheDesktop commented 5 years ago

@weaversam8

So in both your case and mine the problem suddenly disappeared. It does not seem as though there was some thing we both did, so I infer that the problem is intermittent, i.e. dependent on things we know not. But perhaps I miss something.

gorhill commented 5 years ago

There was an issue resembling this in bugzilla, https://bugzilla.mozilla.org/show_bug.cgi?id=1496684, but this was affecting Firefox for Android. I wonder if a similar, rare condition could also be occurring in Firefox Desktop.

Also, one thing I wonder is if the code here can be re-entrant -- I have assumed it is not. If there is re-entrance, this could cause some network requests to never be processed at start up. I strongly doubt re-entrance is possible, but nevertheless I will modify to be shielded against this in the next dev build.

weaversam8 commented 5 years ago

I caught the issue yesterday evening on my other PC before it disappeared, and took a screenshot of the browser console. There's a lot of noise here, probably coming from other extensions, but here's one full page screenshot in case anything jumps out...

image

gorhill commented 5 years ago

I can't find related to uBO in that console output. There seems to be another extension causing all these errors/warning. What else do you have installed?

Sejsel commented 5 years ago

Had the issue with the 65.0.1 (64-bit) stable Windows build that was released yesterday.

After disabling "I am an advanced user" and purging all filter caches, then disabling and enabling the extension I no longer have the issue. I have re-enabled the advanced settings and everything seems to be working now.

When having this issue, I noticed there were no requests being made in the network tab of dev tools at all.

uBlock-user commented 5 years ago

Seems like it was a case of broken Nightly build/corrupted ubo storage.

LinuxOnTheDesktop commented 5 years ago

@uBlock-user I - and others, I believe - have the problem on regular ('release') Firefox.

uBlock-user commented 5 years ago

@LinuxOnTheDesktop Can you still reproduce this ?

LinuxOnTheDesktop commented 5 years ago

Yes, on UBO 1.18.4 on Linux. EDIT: I should say: intermittently.

andyklimczak commented 5 years ago

Experiencing this on Firefox Beta 66.0b4 (64-bit) on linux. First pages will take forever to load. And will eventually load after a few minutes. There are no console error messages. They instantly load if I go to about:addons and disable uBlock

gorhill commented 5 years ago

There is no point just saying you also have the issue, please also provide what is asked above: browser console error, new profile, other extensions interfering, etc. That the issue disappears when disabling uBO does not mean at all the issue lies with uBO, this needs to be further investigated. Since I can't reproduce, someone else will need to step up to investigate beyond reporting "me too".

uBlock-user commented 5 years ago

Updated to the latest Nightly and still cannot reproduce, those who can reproduce post a different set of repro steps for further investigation, otherwise this issue will not go anywhere beyond "me too".

@sciguyryan Were you able to reproduce on a clean profile ?

LinuxOnTheDesktop commented 5 years ago

Here are two sets of - somewhat overlapping - reports from the browser console. The output in report 1 (or some of it, anyway) was produced when, with Firefox (65.0, on Linux) open, I tried to open a Firefox tab, via Thunderbird, onto (so to speak) a github page. The output in report 2 was generated in the way way, including it being github that I was visiting, though this time the github page was this very page here. The second report was generated a few minutes after generating the first.

Report 1 (pastebin) Report 2 (pastebin) Here's some details of my Firefox configuration, too (also on Pastebin)

gorhill commented 5 years ago

I see nothing from uBO in there. I tried opening the current page from within a Thunderbird link, and it opened fine. Does it happen every time you try or just once in a while?

LinuxOnTheDesktop commented 5 years ago

At present the problem seems constant, for gitbhub and bugzilla (so: bugs when reporting bugs - deeply irritating) but the problems with those sites have proved to be merely intermittent in the past. Perhaps the people having problems have some addOns, aside from Unlock, in common. Or else some Firefox setting perhaps.

LinuxOnTheDesktop commented 5 years ago

I think the problem may have to do, at least on Linux, with Firefox being set to show tabs in the titlebar.

gorhill commented 5 years ago

It's why people are asked to find out if an issue also occurs in a new profile with only uBO, this reduces the amount of external variables when trying to narrow down an issue.

LinuxOnTheDesktop commented 5 years ago

@gorhill

Sorry. I have now tested with a new profile and with that I am not - at present anyway - having the problem, even when I tell Firefox to draw titlebars in tabs. EDIT: but I cannot now reproduce the problem even on my main profile!

LinuxOnTheDesktop commented 5 years ago

The problem has reoccured; it is intermittent. Here is some more data from the console (existing profile, Linux) when the bug occured. Hopefully this report contains something relevant (though I fear it does not). ConsoleOutput.txt

LinuxOnTheDesktop commented 5 years ago

Eventually Firefox loaded some pages. New log attached. (The log includes . . a Reddit logo in new.txt ASCII art . .?)

gorhill commented 5 years ago

There is nothing wrong in there, it appears stuff was blocked as expected and it's reported in the console.

uBlock-user commented 5 years ago

Does this happen on cold start/first start of the browser ? Similar thing happened to me on Chromium only on cold start/first start of the browser where github.com won't load if I'm using indexedDB as cacheStorageAPI and would keep displaying this page even after uBO loaded fully --

ps. - just replace doubleclick.net with github.com I had to restart the browser to make it work.

LinuxOnTheDesktop commented 5 years ago

Does this happen on cold start/first start of the browser?

In my case, I think Firefox has to open already.

dont-bug-me commented 5 years ago

I'm not 100% sure if this is the same issue, but if i go to this site it stays completely blank. But I found out what caused the problem at least on that site. The problem has to do with cosmetic filtering. In my uBo settings i have "Parse and enforce cosmetic filters" activated and "Ignore generic cosmetic filters" deactivated. When I deactivate "Parse and enforce cosmetic filters" or activate "Ignore generic cosmetic filters" the site loads just as expected. I can reproduce this behavior with uBo 1.18.4 on the latest stable Firefox and on Firefox 66.0b11.

gorhill commented 5 years ago

@dont-bug-me Filter issue, report the issue to EasyList Germany please.

LinuxOnTheDesktop commented 5 years ago

On Linux, I have "Ignore generic cosmetic filters" enabled and I still have the problem.

quassy commented 5 years ago

I can confirm this with uBlock Origin 1.18.4 on Firefox 66.0b13 (64-Bit) on Windows 10 with an existing profile (with my normal extensions as well as uBlock Origin being the only extension) and had this problem since monday, but I am too unable to reproduce with a new profile. What might give a hint for troubleshooting is that, after restarting Firefox, uBlock does not remember any settings (e.g. Show number of blocked elements on icon) or custom filters, even the dynamic filtering list and white list are completely blank, even though they should be filled by default.

This does affect not most of my extensions, but Tab Center Redux is also broken and does not remember any settings.

When debugging uBlock Origin and trying to change some settings (checking checkboxes, adding a new custom filter), the same types of error messages are logged in console on every operation (the output for Tab Center Redux is similar, always referring to ExtensionUtils.jsm and storage.js:633):

Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. ExtensionUtils.jsm
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. storage.js:633
Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. ExtensionUtils.jsm
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. storage.js:633
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. assets.js:682
TypeError: "Response has unsupported MIME type" lz4-block-codec-wasm.js:148:17
Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. ExtensionUtils.jsm
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. storage.js:633
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. assets.js:682
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. assets.js:701
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. storage.js:633
Unchecked lastError value: Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. assets.js:682
Error: UnknownError: The operation failed for reasons unrelated to the database itself and not covered by any other error code. ExtensionUtils.jsm
uBlock-user commented 5 years ago

What might give a hint for troubleshooting is that, after restarting Firefox, uBlock does not remember any settings (e.g. Show number of blocked elements on icon) or custom filters, even the dynamic filtering list and white list are completely blank, even though they should be filled by default. This does affect not most of my extensions, but Tab Center Redux is also broken and does not remember any settings.

Different issue suffered by using private mode/never remembering history, not related to this. Fixed in the dev build.

quassy commented 5 years ago

To add to my comment: The errors seem to be related to IndexedDB, which is probably the way uBlock Origin and Tab Center Redux save their settings. Deleting the contents of profile_folder/storage/ solves the problem, so maybe the databases there got corrupted by a Firefox update.

Different issue suffered by using private mode/never remembering history, not related to this. Fixed in the dev build.

I am not using always-private mode and do keep my browsing history, only blocking third-party cookies and always use tracking protection (list 1).

gorhill commented 5 years ago

Form the errors you report above, it seems the issue is with Firefox WebExtensions's browser.storage.local -- so unrelated to uBO's use of IndexedDB for caching purpose. This could be a case of corrupted storage. It would be useful to report the line of the error message for ExtensionUtils.jsm. This is probably something to report to Firefox devs.

gorhill commented 5 years ago

@uBlock-user

Fixed in the dev build.

The reported error messages are unrelated to this. The issue as per error messages is with browser.storage.local. This might be related to the fact that Firefox migrated extension storage from JSON-based to IndexedDB-based.

gorhill commented 5 years ago

@quassy Do you have a lot of custom filters? I am wondering if Firefox started to enforce unlimitedStorage permission.

quassy commented 5 years ago

@quassy Do you have a lot of custom filters? I am wondering if Firefox started to enforce unlimitedStorage permission.

Not really, but can't tell for sure (as I have reset storage now and restoring it will restore the bug / make the list impossible to view). Probably less than 100, so nowhere near any storage limit Firefox will enforce (I'd guess something between 10 MB to 2 GB). Also Tab Center Redux has only minimal settings and is even less likely to hit any limit.

Is there any way to find out, which storage files belong to uBlock, to check its size (and maybe contents with SQLite)?

gorhill commented 5 years ago

Is there any way to find out, which storage files belong to uBlock

Here is what I observe with my Nightly/Linux installation:

You can find uBO-unique-id in about:debugging#addons. The numeric values seen in there might be different on your side I suppose.

The sizes on my side are as expected, under 100KB.

If you have a SQlite viewer, you could check whether the storage is corrupted.

agentjsp commented 5 years ago

I get this same issue with the Firefox 66 release candidate. Happened right after the last update (like a day ago) and didn't happen on the last beta build. I'm on the beta channel.

I have uBlock Origin disabled until further notice, because no page loads when it's enabled.

gorhill commented 5 years ago

Try uBO in a new profile with no other extensions or about:config changes. As often mentioned, something else might interfere negatively and uBO is merely making this apparent.

uBlock-user commented 5 years ago

Should this still be kept open given it's going nowhere and OP has failed to provide feedback ?

agentjsp commented 5 years ago

@gorhill It appears to work in a new profile. Absolutely nothing has changed between the update though (besides going from the latest beta to RC1), so if something is interfering negatively the add-on may need to be updated or the Firefox devs may need to be notified. I cleared my cache through the normal means, but I'm not sure if that clears the kind of storage mentioned in earlier posts. I get absolutely nothing in the console by the way, just the infinite loading symbol in the tab header. Something interesting is that if you attempt to visit webpages, none of them will load, but the moment you disable the add-on the requests will go through.

@uBlock-user Why would it be closed given that it's a critical bug that is preventing some people from using the software?