search

uDALES / u-dales

uDALES: large-eddy-simulation software for urban flow, dispersion and microclimate modelling
https://udales.github.io/u-dales
GNU General Public License v3.0
54 stars 18 forks source link

Switch CI service from Travis to GH Actions #104

Closed dmey closed 3 years ago

dmey commented 3 years ago

@bss116 and @samoliverowens I noticed that jobs fails for the namoptions.driven on mac but I think it's probably easier to get this merged in first and have a look at the tests again in a separate issue/PR as they may be outdated.

bss116 commented 3 years ago

Okay, very strange that it works for ubuntu but not for mac. It seems to be failing for the driver simulation.

dmey commented 3 years ago

Okay, very strange that it works for ubuntu but not for mac. It seems to be failing for the driver simulation.

Well we use GNU 7 in Ubuntu and 9 in macOS so that could be the reason -- we could remove support for GNU 9 as well but I'd prefer to do that when we clean up the tests cases through #19 -- they're maybe issue with the current tests and recent changes we merged in.

bss116 commented 3 years ago

I think updating the test cases is still a bit of work, especially if bugs in the driver simulations are creeping up; I will not have time to do this. We'd have a failing build in the meantime. Is there a reason to switch CI or now can it be done after we updated the tests?

dmey commented 3 years ago

The driver simulation was failing on Travis as well. They were doing it silently though as there was a bug in the test script which I fixed. In effect this PR has nothing to do with the failing job, it just happened that I picked up in here. And re the move just speed really. Travis was taking ages to finish the builds on macOS. Here we get more resources.

dmey commented 3 years ago

I think updating the test cases is still a bit of work, especially if bugs in the driver simulations are creeping up; I will not have time to do this.

That's fine I can have a look at the compiler issue separately/use the tests in #19

bss116 commented 3 years ago

The driver simulation was failing on Travis as well. They were doing it silently though as there was a bug in the test script which I fixed. In effect this PR has nothing to do with the failing job, it just happened that I picked up in here. And re the move just speed really. Travis was taking ages to finish the builds on macOS. Here we get more resources.

Ok I see, so if the tests are already failing, then we might as well show it, by merging in this change ;)