search

uDALES / u-dales

uDALES: large-eddy-simulation software for urban flow, dispersion and microclimate modelling
https://udales.github.io/u-dales
GNU General Public License v3.0
47 stars 17 forks source link

Reduce input files (closes #78 #93). #108

Closed samoliverowens closed 3 years ago

samoliverowens commented 3 years ago

This PR address issues #78 and #93. It removes the need for Tfacinit.inp unless lEB == .true. or iwalltemp == 2, and removes the need for facets.inp and walltypes.inp when nfcts == 0.

initfac has also been reformatted, so it looks like a lot of changes - I'd suggest hiding whitespace changes when viewing the changes.

bss116 commented 3 years ago

Looks good to me. Can you please also remove the input files from the examples that are no longer needed? You checked that they are working with the changes, right?

bss116 commented 3 years ago

@samoliverowens please delete the branch once it is merged (can be restored again if needed). I noticed that it did not close the issue 93 automatically, apparently it does not work with "close x AND y" in the title, seems like we need to use "close x y" instead.