search

uDALES / u-dales

uDALES: large-eddy-simulation software for urban flow, dispersion and microclimate modelling
https://udales.github.io/u-dales
GNU General Public License v3.0
54 stars 18 forks source link

Use correct stderror steam (0). (Closes #123) #126

Closed dmey closed 3 years ago

dmey commented 3 years ago

Changes write stream to 0 for stderr -- see https://en.wikipedia.org/wiki/Standard_streams#1950s:_Fortran

dmey commented 3 years ago

Do you also need to change something in the hpc_execute.sh and local_execute.sh files? The errors still go to the output.xxx file.

I have already started to change some in the plots PR but will fix all those in a different PR.

bss116 commented 3 years ago

Do you also need to change something in the hpc_execute.sh and local_execute.sh files? The errors still go to the output.xxx file.

I have already started to change some in the plots PR but will fix all those in a different PR.

Why not change them directly here?

dmey commented 3 years ago

Do you also need to change something in the hpc_execute.sh and local_execute.sh files? The errors still go to the output.xxx file.

I have already started to change some in the plots PR but will fix all those in a different PR.

Why not change them directly here?

I feel like this is more core to the code rather then those utilities scripts. Given that nothing is broken and those scripts need to be a bit of refactoring anyways I think it would be more proper to do it in a separate if you dont mind.