search

uDALES / u-dales

uDALES: large-eddy-simulation software for urban flow, dispersion and microclimate modelling
https://udales.github.io/u-dales
GNU General Public License v3.0
47 stars 16 forks source link

Fixes to bottom edge wall function as identified in #23 (closes #23) #135

Closed tomgrylls closed 3 years ago

tomgrylls commented 3 years ago

1) Fixes to the allocation of cells when dealing with the wall function for the bottom edge of buildings. The 5th column of blocks is now called as this contains information on the lower vertical index of each block. This has limited application as in the majority of cases the starting position is kl = 0 and we do not have floating or overhanging blocks. But is applied in complex morphologies and ensures consistency in the code.

2) A fix for the u top edge east where index i was not being updated to ensure that that the wall function was applied on the east face of the wall. The new line ensures the i index is properly allocated. This is now consistent with similar lines such as under case(22).

These bugs were identified in #23 . wfmneutral is based upon wf_uno and that is why the same fixes are required in both. Following this pull request #23 can be closed as @ivosuter has confirmed that wfmneutral fixes that issue and has been checked for bugs.

tomgrylls commented 3 years ago

@dmey this will not affect any preprocessing scripts or cases.

ivosuter commented 3 years ago

Yeah I think Tom changed what I proposed, so that's ok.

dmey commented 3 years ago

@tomgrylls can you merge it in before releasing 1.0.0?