Closed dmey closed 3 years ago
@ivosuter is best placed to advise on the first set you have listed. From my understanding, these are modules that were added by either @ivosuter or Jasper Tomas. They are not all IBM related but have been added since this branched from DALES.
The second set are all wall functions that were added by @ivosuter and me so should be uDALES.
modibm.f90 modibmdata.f90 modinlet.f90 modinletdata.f90 modsave.f90
Are all from Jasper and probably modified by us later (originate from DALESURBAN_136, Jaspers version we built upon). None of them are in DALES 3.2 or DALES 4.0, so they must have been added by Jasper himself.
Are all from Jasper and probably modified by us later (originate from DALESURBAN_136, Jaspers version we built upon). None of them are in DALES 3.2 or DALES 4.0, so they must have been added by Jasper himself.
OK thanks -- will use the DALES header for these then.
@ivosuter @tomgrylls this is now ready for review could approve/let me know for any changes please?
This all looks okay to me. One question before approving. Modules like modboundary
are now highly modified versions of the original DALES modules. Is this implied through the licensing text or should it be said that modules like that are edited versions of the originals too?
One question before approving. Modules like modboundary are now highly modified versions of the original DALES modules. Is this implied through the licensing text or should it be said that modules like that are edited versions of the originals too?
So if these were originally provided in DALES and you modified them (no matter by how much) the original licence and copyright still applies. You can only change a licence and copyright if this is created by yourself.
This PR adds/updates the licence header and copyright notice. @tomgrylls and @ivosuter please can you check and let me know.
~There are however a few files which have no authorship information and are not included in the dales repo therefore I am not sure which copyright should apply (i.e. DALES or uDALES). Could you please check the following files and let me know?~
~1. These seem to be IBM related so I think they should be DALES but please double check:~
~modibm.f90~ ~modibmdata.f90~ ~modinlet.f90~ ~modinletdata.f90~ ~modsave.f90~
~2. These I don't know:~
~wf_gr.f90~ ~wf_uno.f90~ ~wfmneutral.f90~
EDIT: point 1 is addressed in 51cff24 and point 2 in e580661