search

uDALES / u-dales

uDALES: large-eddy-simulation software for urban flow, dispersion and microclimate modelling
https://udales.github.io/u-dales
GNU General Public License v3.0
47 stars 16 forks source link

Use latest gfortran version in tests and fix debug compilation. #150

Closed samoliverowens closed 1 year ago

samoliverowens commented 1 year ago

Commit https://github.com/uDALES/u-dales/commit/26fe1fa1fe016f1277f494132630ada1cdc8ad70 enables compilation using gfortran 10 and above, but the tests use gfortran version 9. This PR updates the test to use the latest version of gfortran.

pbartholomew08 commented 1 year ago

Judging by the error:

Error: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-1)
/home/runner/work/u-dales/u-dales/src/initfac.f90:367:24:

  195 |       call MPI_BCAST(nwalltypes, 1, MPI_Integer, 0, comm3d, mpierr)
      |                     2   
......
  367 |          call MPI_BCAST(facets, 4*nfcts, MPI_Integer, 0, comm3d, mpierr)
      |                        1
Error: Rank mismatch between actual argument at (1) and actual argument at (2) (scalar and rank-2)

I think you need to pass -fallow-argument-mismatch for the GNU builds.

samoliverowens commented 1 year ago

I do - ubuntu release is passing, but debug doesn't because -fallow-argument-mismatch is not enough to turn this into a warning rather than an error. I gave up with macos because I couldn't get it to use the latest version of gfortran in the tests.

pbartholomew08 commented 1 year ago

ah, ok, that just looked like the errors I used to see when gfortran changed its behaviour.