uDALES / u-dales

uDALES: large-eddy-simulation software for urban flow, dispersion and microclimate modelling
https://udales.github.io/u-dales
GNU General Public License v3.0
54 stars 18 forks source link

Improve statistics output modstatsdump.f90 #57

Open bss116 opened 4 years ago

bss116 commented 4 years ago

This issue addresses code improvement and further functionalities for the statistics routine modstatsdump.f90. Code improvement: The code has currently some statistics calculations hardcoded for each variable. This should be replaced by generic functions and function calls for the variables. Care needs to be taken about static or dynamic allocation of output arrays, when the number of output variables is only determined at runtime. Additional features: Adding the block masks as statistics output can be useful for post-processing. Currently the lowest (floor) level is masked in the statistics output. I would suggest to instead not output it at all and move the z-axes accordingly.

Summary of tasks:

tomgrylls commented 4 years ago

As opposed to creating some automated way of changing the size of the netcdf files depending on switches like ltempeq, lmoist etc. A potentially simpler change would be to separate these output files completely. As opposed to having tdump.xxx.nc with all outputs of interest, we have m.tdump.xxx.nc (momentum), T.tdump.xxx.nc (temperature), s1.tdump.xxx.nc (first scalar field) etc. And so on for ytdump, xytdump etc.? This relates to #42.