search

uNetworking / uSockets

Miniscule cross-platform eventing, networking & crypto for async applications
Apache License 2.0
1.29k stars 268 forks source link

Hammer test fails on macOS #64

Closed ghost closed 3 years ago

ghost commented 5 years ago

Most probably kqueue

ghost commented 3 years ago

What happens on macOS is that connect fails, if you run the test in rapid succession many times over. Probably because it uses up all sockets or something;

Anyways, so connect fails from kqueue reporting EV_ERROR and from there we report this ERROR as a succesful open event, which is a bug.

So the client support needs fixing and I have a diff here that makes everything work but it will require the addition of a new callback, and 3 new functions to make it properly working. With this diff, hammer test never fails on macOS

After this has been fixed, github actions should be made to run hammer_test on linux and macOs with every commit

ghost commented 3 years ago

This is fixed now. It was a combination of macOS peculiarities (such as getting stuck in FIN_WAIT_2) and lacking client error handling. Now hammer tests run on linux and macOS on all pushes.