uNetworking / uWebSockets.js

μWebSockets for Node.js back-ends :metal:
Apache License 2.0
7.64k stars 560 forks source link

node 22 #1049

Closed yovanoc closed 4 weeks ago

yovanoc commented 2 months ago

How can we help to ship node 22 binaries? thanks

uNetworkingAB commented 2 months ago

I will have a look within a week

yovanoc commented 2 months ago

Ok, thanks!

aleksraiden commented 2 months ago

Also waiting, a lot of thanks

aleksraiden commented 2 months ago

Current upstream from repo works fine with 22.1 node

yovanoc commented 2 months ago

Current upstream from repo works fine with 22.1 node

the version 20.43 still doesn't work for me with node 22.1

aleksraiden commented 2 months ago

Current upstream from repo works fine with 22.1 node

the version 20.43 still doesn't work for me with node 22.1

check an version from repo, not release

uNetworkingAB commented 2 months ago

1031

Sceat commented 1 month ago

Current upstream from repo works fine with 22.1 node

the version 20.43 still doesn't work for me with node 22.1

check an version from repo, not release

we still the need the compiled binaries, how do you install from upstream ?

aleksraiden commented 1 month ago

we still the need the compiled binaries, how do you install from upstream ?

We are using a binary from this commit - https://github.com/uNetworking/uWebSockets.js/tree/bcb70ea44395eb59f695860b4b37db90387d86de and all works fine

Sceat commented 1 month ago

@aleksraiden on what infra are you running ?

using "uWebSockets.js": "github:uNetworking/uWebSockets.js#bcb70ea44395eb59f695860b4b37db90387d86de"

I still get: (on mac M1 & node 22.1)

path/node_modules/uWebSockets.js/uws.js:22
        throw new Error('This version of uWS.js supports only Node.js LTS versions 16, 18 and 20 on (glibc) Linux, macOS and Windows, on Tier 1 platforms (https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list).\n\n' + e.toString());
              ^

Error: This version of uWS.js supports only Node.js LTS versions 16, 18 and 20 on (glibc) Linux, macOS and Windows, on Tier 1 platforms (https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list).

Error: Module did not self-register: 'path/node_modules/uWebSockets.js/uws_darwin_arm64_127.node'.
    at path/node_modules/uWebSockets.js/uws.js:22:9
    at Object.<anonymous> (path/node_modules/uWebSockets.js/uws.js:24:3)
Sceat commented 1 month ago

and on the latest commit for the binaries 4181846d36bf1f19a6f2eb59f5add8494dfabbe4

I get dyld[6162]: missing symbol called

cc: @uNetworkingAB

Veradictus commented 1 month ago

^ Same here

uNetworkingAB commented 1 month ago

Node 22 support is not released yet

Sceat commented 1 month ago

Any blocker?

uNetworkingAB commented 1 month ago

Windows is not building

Sceat commented 1 month ago

Is it a blocker for other distros ?

e3dio commented 1 month ago

Just download correct file from here https://github.com/uNetworking/uWebSockets.js/tree/binaries

uNetworkingAB commented 4 weeks ago

this is now released