uNetworking / uWebSockets.js

μWebSockets for Node.js back-ends :metal:
Apache License 2.0
7.86k stars 569 forks source link

Build for arm 32-bit #822

Closed adonespitogo closed 1 year ago

adonespitogo commented 1 year ago

Tested on raspberry pi 3 Model B.

uNetworkingAB commented 1 year ago

This is 100% unsupported but looks like it won't harm to have it there

adonespitogo commented 1 year ago

@uNetworkingAB Can you elaborate why this is not supported? And if it is not supported, is it still possible to add a binary for 32-bit arm?

I really needed this to work on RPI and other SBC's for our project.

uNetworkingAB commented 1 year ago

What I mean is, none of the 32-bit platforms are tested. I haven't had a 32-bit system in many years and never will.

adonespitogo commented 1 year ago

I can do the testing for 32-bit systems if you're open to it. Actually we are a small company and our products run mostly on SBCs and microprocessors. We will definitely allocate some resources for testing your project to ensure it runs on all of our supported products. Will you accept if we submit binaries for 32 bit systems? And may we know how to get those binaries in the final releases of this package?

adonespitogo commented 1 year ago

Today I will also be testing other boards and see if it compiles. These boards in particular are:

We have many more boards like Nano Pi, Tinker Board, Late Panda etc. to test but these are my priorities for today.

uNetworkingAB commented 1 year ago

Obviously I cannot accept binaries from third party as that would open for supply chain attack of the year 😉 If they work, they work, but I don't have resources to support edge case hardware (at some point someone will want to run uws on an 8 bit heart rate monitor) so you could just upload your binaries to your own repo and instqll from there. 👍

adonespitogo commented 1 year ago

Fair enough. Right now I'm trying to create my own package which contains the 32 bit binaries. I'm fiddling with the github workflows and so far I'm able to build binaries for armv6 and armv7. I'm just wondering how you build the nodejs package since there's no package.json in the repo. Do you have other scripts for deploying the release of this package?

adonespitogo commented 1 year ago

Oh now I see, it's all in the binaries branch.