uNetworking / uWebSockets.js

μWebSockets for Node.js back-ends :metal:
Apache License 2.0
7.86k stars 569 forks source link

Arm 32bit support #825

Closed adonespitogo closed 1 year ago

adonespitogo commented 1 year ago

Hi,

First of all, thanks for this great project and for sharing your commendable talent and skills to the open source community.

As I've mentioned before in my previous PR about submitting 32bit binaries for ARM, I've figured out how to generate binaries automatically using your github actions script. Right now it is able to build for armv7 architecture. Although you've mentioned that you won't support 32-bit arm, I hope you can include this build script so that other people that need this can use your library without having to fork it.

In my use case, I am using hyper-express (express-like library on top of uWebSockets.js). Without 32-bit support from uWebSockets.js, I will have to fork both hyper-express and uWebSockets.js which adds a bit of friction when trying to keep up with the latest releases from both package. I hope you can consider merging this PR.

uNetworkingAB commented 1 year ago

Looks like you scratched your own itch, and also fixed the arm64 binaries being built by GH 👍

adonespitogo commented 1 year ago

Thanks for accepting my PRs. It was a bit messy but I'll to keep it concise next time 👍