search

uNetworking / uWebSockets.js

μWebSockets for Node.js back-ends :metal:
Apache License 2.0
7.76k stars 563 forks source link

Would it be possible to add a (small) stack trace to the warnings related to `res.cork` which started from v20.26.0? #920

Closed hawkerboy7 closed 1 year ago

hawkerboy7 commented 1 year ago

Hi Alex Hultman,

Thank you for this project! Would it be possible to add a (small) stack trace to the warnings related to res.cork which started from v20.26.0?

It looks asif I've placed all .writeStatus, .writeHeader, .end, .write, .tryEnd, .upgrade, .endWithoutBody, or similar within a res.cork, and am not running any async actions afterwards, but I am still seeing some warnings and it is a bit hard to see where they come from.

Though not nessisary, since the instructions are clear, this would help in identifing the source of the problem a lot better.

hawkerboy7 commented 1 year ago

In the meantime I did find the source where the res.cork's were missing.

and am not running any async actions afterwards

This was incorrect. Question still stands though :)

uNetworkingAB commented 1 year ago

Good. It means the warning is working :D