uPagge / uBlogger

A template designed with your readers in mind :heart:
https://ublogger.netlify.app
MIT License
250 stars 101 forks source link

[BUG] Light/Dark theme changes cause JS errors #110

Open fmueller opened 3 years ago

fmueller commented 3 years ago

Describe the bug

I recognized my browser console being polluted by JS errors when I changed from light to dark theme, back and forth. Error in the console is: "Uncaught TypeError: window.REMARK42.changeTheme is not a function". It looks like you want to switch to a light/dark theme at Remark42 comment solution as well. But I do not use it.

I was able to hotfix this with a custom script that defines an empty function and mimics Remark42:

window.REMARK42 = {

    changeTheme: function (anything) {
        // do nothing
    }
}

Expected behavior

No JS errors when there is no Remark42 used and I click on 'change to the light/dark theme'.

Build Environment

Preview Environment

uPagge commented 3 years ago

Thanks for the find, I will fix it soon