uPortal-Attic / uportal-app-framework

Framework for creating uPortal Applications
http://uportal-project.github.io/uportal-app-framework/
Apache License 2.0
23 stars 31 forks source link

Redirect in miscService.redirectUser on 401, 302, and 0 specifically #1016

Closed apetro closed 3 years ago

apetro commented 3 years ago

On reflection, https://github.com/uPortal-Project/uportal-app-framework/pull/1014 went too far in making any status redirect the user in miscService.redirectUser(). In particular this made 404s redirect.

Instead, add status 401 specifically to the statuses that cause redirects. This will keep the newfound support for detecting when APIs are failing because the user isn't logged in and for automatically handling this case, with fewer under-considered side effects.


Review for security considerations

PR considerations checklist: