search

uPortal-Attic / uportal-home

Alternative UI for Apereo uPortal (originally built for MyUW)
http://uportal-project.github.io/uportal-home/
Apache License 2.0
25 stars 27 forks source link

Releasing is a bit of a pain #724

Open davidmsibley opened 7 years ago

davidmsibley commented 7 years ago

I just want to note all the little things that I'm constantly tripping over while running releases, so I can remember them next time, or we alleviate them.

The License Plugin picks up on files that are .gitignore'd, like endpoint.properties or src/main/webapps/META-INF/context.xml so basically you need a completely clean checkout for it to work.

The NOTICE file plugin will fail you if you don't have two empty lines at the end of your notice file.

Since the commitmsg hooks will fail a maven release, you need to remove the commitmsg line from package.json, then run mvn -DcheckModificationExcludeList=package.json release:prepare

ChristianMurphy commented 7 years ago

I just want to note all the little things that I'm constantly tripping over while running releases, so I can remember them next time, or we alleviate them.

Thanks @davidmsibley! Collecting retrospective information is incredibly helpful for tuning development lifecycle :wrench:

The License Plugin picks up on files that are .gitignore'd, like endpoint.properties or src/main/webapps/META-INF/context.xml so basically you need a completely clean checkout for it to work.

http://www.mojohaus.org/license-maven-plugin/check-file-header-mojo.html#excludes

The NOTICE file plugin will fail you if you don't have two empty lines at the end of your notice file.

PR's are welcome :smile: https://github.com/Jasig/maven-notice-plugin

Since the commitmsg hooks will fail a maven release, you need to remove the commitmsg line from package.json, then run mvn -DcheckModificationExcludeList=package.json release:prepare

:thinking: I suspect the missing space between chore(release): and the message body is causing the error. Its odd that the space is missing, since the provided prefix does include a space.

https://github.com/uPortal-Project/uportal-home/blob/39b41020ecf2ec9c1c1cad7c8b05e91a37abba81/pom.xml#L161

apetro commented 7 years ago

726 might help, not in magically addressing any of the pain points described here, but at least in forcing them to stay addressed more frequently.

apetro commented 5 years ago

(I pinned this issue because I'm reliant on finding it again to successfully cut releases; of course it'd be a fine thing to harvest the insights or even make the build and release process better so that no one need rely on finding this issue again.)