uPortal-Attic / uportal-home

Alternative UI for Apereo uPortal (originally built for MyUW)
http://uportal-project.github.io/uportal-home/
Apache License 2.0
25 stars 27 forks source link

fix(search): gracefully handle more directory search failure modalities #825

Closed apetro closed 6 years ago

apetro commented 6 years ago

When directory search fails for bad directory search URL config (as is the case with naive localhost demo of mvn clean package && mvn jetty:run), fail with user-facing message and console log message, and stop the loading indicator.

After:

after-handle-directory-search-failure

Before:

before-bad-dir-search-hangs-foreverish

apetro commented 6 years ago

The failed AppVeyor check looks like a false negative.


> @uportal/home@7.0.1 test C:\projects\uportal-home
> karma start web/target/web/karma.conf.js --single-run "--browsers" "ChromeHeadless,Firefox,IE"
07 06 2018 10:27:50.484:INFO [karma]: Karma v2.0.2 server started at http://0.0.0.0:9876/
07 06 2018 10:27:50.489:INFO [launcher]: Launching browsers ChromeHeadless, Firefox, IE with unlimited concurrency
07 06 2018 10:27:50.502:INFO [launcher]: Starting browser ChromeHeadless
07 06 2018 10:27:50.560:INFO [launcher]: Starting browser Firefox
07 06 2018 10:27:50.583:INFO [launcher]: Starting browser IE
07 06 2018 10:27:56.095:INFO [HeadlessChrome 0.0.0 (Windows 10 0.0.0)]: Connected on socket K0_NzfHQxPEPE_A4AAAA with id 68100048
...07 06 2018 10:27:58.720:INFO [IE 11.0.0 (Windows 10 0.0.0)]: Connected on socket r7PC3xh8t5E1cO05AAAB with id 79094129
........
HeadlessChrome 0.0.0 (Windows 10 0.0.0): Executed 11 of 11 SUCCESS (0.347 secs / 0.337 secs)
...........
IE 11.0.0 (Windows 10 0.0.0): Executed 11 of 11 SUCCESS (0.396 secs / 0.267 secs)
07 06 2018 10:28:02.865:INFO [Firefox 59.0.0 (Windows 10 0.0.0)]: Connected on socket uEs_khwnKL8Duv4UAAAC with id 95837543
07 06 2018 10:28:12.867:WARN [Firefox 59.0.0 (Windows 10 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.
Firefox 59.0.0 (Windows 10 0.0.0) ERROR
  Disconnected, because no message in 10000 ms.
Firefox 59.0.0 (Windows 10 0.0.0): Executed 0 of 0 DISCONNECTED (10.002 secs / 0 secs)
07 06 2018 10:28:17.835:INFO [coveralls.io]: uploading...
07 06 2018 10:28:17.835:INFO [coveralls.io]: 422 --- {"message":"Couldn't find a repository matching this job.","error":true}
npm ERR! Test failed.  See above for more details.
Command exited with code 1