regeneratorRuntime is not defined

[jonathanmtran]

Describe the bug A regeneratorRuntime is not defined is preventing the modal notification from rendering

To Reproduce

1. Deploy portlet with a modal notification web component such as jasig/uPortal-start#226
2. Open developer tools
3. Navigate to the page containing the modal notification web component

Expected behavior A notification modal

Screenshots

Platform:

• Notification Portlet Version: 4.3.1
• Browser: Chrome/ium and Firefox

[ChristianMurphy]

[ChristianMurphy]

Looking into this now :mag:

[ChristianMurphy]

@jonathanmtran a work around is adding <script src="https://unpkg.com/regenerator-runtime@0.12.1/runtime.js"></script> https://github.com/uPortal-contrib/uPortal-web-components/issues/117 will probably be the long term fix to prevent this from coming up again as new components get added.

[jonathanmtran]

Adding <script src="https://unpkg.com/regenerator-runtime@0.12.1/runtime.js"></script> works for Chrome/ium On the other hand, the modal doesn't render on Firefox

[ChristianMurphy]

What version of notification are you using?

That should have been fixed when https://github.com/Jasig/NotificationPortlet/blob/e673a002469ecb3179afcf7eb3692814520e555d/notification-portlet-webcomponents/notification-modal/src/components/NotificationModal.vue#L179-L183

was added in https://github.com/Jasig/NotificationPortlet/commit/dcd0f11c88e70e2b360cec62615d115e07329388, included in v4.3.1+

[ChristianMurphy]

Is it still happening in 4.3.1 on your system?

[jonathanmtran]

@ChristianMurphy Yes. I've deployed 4.3.1 and it still doesn't render/appear on Firefox

[ChristianMurphy]

@jonathanmtran I tested this with uPortal 5.3.0 and a snapshot of the master branch of this repo (soon to be officially released). I'm seeing it work on Chrome, Firefox, and Edge.

Let me know if you run into any other issues, we could hop on a video call and debug.

[ChristianMurphy]

Notification portlet 4.4.0 includes the fixes