search

uPortal-Project / uPortal-web-components

A collection of uPortal Web Components and JavaScript utilities
https://uportal-project.github.io/uPortal-web-components
Apache License 2.0
24 stars 25 forks source link

feat: added grid-carousel component #1042

Closed rmathis closed 12 months ago

rmathis commented 12 months ago

Adds a grid-carousel component, designed for the favorites portlet, for mobile and desktop use.

rmathis commented 12 months ago

Could you update the lockfile? Currently CI is failing with:

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! 
npm ERR! Missing: stylelint-processor-styled-components@^1.10.0

https://github.com/uPortal-Project/uPortal-web-components/actions/runs/5511887105/jobs/10048023842?pr=1042#step:4:5

Fixed

rmathis commented 12 months ago

It may be unrelated to this change, but the changelog file is now flagging missing links. https://github.com/uPortal-Project/uPortal-web-components/actions/runs/5489886323/jobs/10004613577?pr=1042#step:6:56

CHANGELOG.md
      12:4-12:14  warning  Found reference to undefined definition                   no-undefined-references   remark-lint
      17:4-17:14  warning  Found reference to undefined definition                   no-undefined-references   remark-lint
      21:4-21:14  warning  Found reference to undefined definition                   no-undefined-references   remark-lint
  1422:1-1422:94  warning  Do not use definitions with the same identifier (1421:1)  no-duplicate-definitions  remark-lint

This isn't specific to my branch, but rather because the version links in this file don't actually link anywhere. I previously copied the code that existed when creating a new release, and they were previously empty. Where should they link to? a tag?

ChristianMurphy commented 12 months ago

I believe we've been linking these to the GitHub commit difference between releases. Some example from previous releases (all at the bottom of the changelog.md file)

[unreleased]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.39.0...HEAD
[1.37.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.38.1...v1.39.0
[1.37.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.36.0...v1.37.0
[1.36.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.35.0...v1.36.0
[1.35.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.3...v1.35.0
[1.34.3]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.2...v1.34.3
[1.34.2]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.1...v1.34.2
[1.34.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.0...v1.34.1
[1.34.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.33.2...v1.34.0
[1.33.2]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.33.1...v1.33.2
[1.33.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.33.0...v1.33.1
[1.33.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.32.1...v1.33.0
[1.32.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.32.0...v1.32.1
[1.32.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.31.1...v1.32.0
[1.31.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.31.0...v1.31.1
[1.31.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.30.1...v1.31.0
[1.30.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.30.0...v1.30.1
[1.30.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.29.0...v1.30.0
[1.29.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.28.0...v1.29.0
[1.28.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.27.0...v1.28.0
[1.27.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.26.2...v1.27.0
[1.26.2]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.26.1...v1.26.2
[1.26.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.26.0...v1.26.1
[1.26.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.25.0...v1.26.0
[1.25.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.24.0...v1.25.0
[1.24.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.23.0...v1.24.0
rmathis commented 12 months ago

It may be unrelated to this change, but the changelog file is now flagging missing links. https://github.com/uPortal-Project/uPortal-web-components/actions/runs/5489886323/jobs/10004613577?pr=1042#step:6:56

CHANGELOG.md
      12:4-12:14  warning  Found reference to undefined definition                   no-undefined-references   remark-lint
      17:4-17:14  warning  Found reference to undefined definition                   no-undefined-references   remark-lint
      21:4-21:14  warning  Found reference to undefined definition                   no-undefined-references   remark-lint
  1422:1-1422:94  warning  Do not use definitions with the same identifier (1421:1)  no-duplicate-definitions  remark-lint

Fixed

rmathis commented 12 months ago

I believe we've been linking these to the GitHub commit difference between releases. Some example from previous releases (all at the bottom of the changelog.md file)

[unreleased]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.39.0...HEAD
[1.37.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.38.1...v1.39.0
[1.37.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.36.0...v1.37.0
[1.36.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.35.0...v1.36.0
[1.35.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.3...v1.35.0
[1.34.3]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.2...v1.34.3
[1.34.2]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.1...v1.34.2
[1.34.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.34.0...v1.34.1
[1.34.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.33.2...v1.34.0
[1.33.2]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.33.1...v1.33.2
[1.33.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.33.0...v1.33.1
[1.33.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.32.1...v1.33.0
[1.32.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.32.0...v1.32.1
[1.32.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.31.1...v1.32.0
[1.31.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.31.0...v1.31.1
[1.31.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.30.1...v1.31.0
[1.30.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.30.0...v1.30.1
[1.30.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.29.0...v1.30.0
[1.29.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.28.0...v1.29.0
[1.28.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.27.0...v1.28.0
[1.27.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.26.2...v1.27.0
[1.26.2]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.26.1...v1.26.2
[1.26.1]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.26.0...v1.26.1
[1.26.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.25.0...v1.26.0
[1.25.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.24.0...v1.25.0
[1.24.0]: https://github.com/uPortal-contrib/uPortal-web-components/compare/v1.23.0...v1.24.0

Fixed