unit test implemented - Githubissues

uPortal-Project / uPortal

Enterprise open source portal built by and for the higher education community.

https://www.apereo.org/projects/uportal

Apache License 2.0

272 stars 273 forks source link

unit test implemented #2715

Closed snehit221 closed 11 months ago

snehit221 commented 11 months ago

Checklist

[x] the individual contributor license agreement is signed
[ ] commit message follows commit guidelines
[x] tests are included
[ ] documentation is changed or added
[ ] new security keys and comments added to security.properties
[ ] new general keys and comments added to portal.properties
[x] any changes that impact configuration or the database DDL added to CHANGES.md
x[] have been updated with new phrases
[x] view conforms with WCAG 2.0 AA

Description of change

Aim is to increase the test coverage, line coverage and branch coverage of the modules I have implemented the unit tests for.

ChristianMurphy commented 11 months ago

Welcome @snehit221! 👋 Thanks for taking the time to contribute!

When you have a chance, could you submit the Apereo ICLA? https://www.apereo.org/licensing/agreements/icla
The tests are currently failing due to formatting, could you run ./gradlew goJF and commit the updated files?
To confirm your goal, you are aiming to increase test coverage? (Very much appreciated) Or is there also a bug you are trying to reproduce?

ChristianMurphy commented 11 months ago

@snehit221 friendly reminder, this still has some open questions 🔔

snehit221 commented 11 months ago

@ChristianMurphy , Thanks for your revert. I have fixed the formatting issues as advised and filled the form as well. My primary goal was to increase the test coverage. I will explore more and will now try to find implementation / design smells and refactor them.