uPortal-Project / uPortal

Enterprise open source portal built by and for the higher education community.
https://www.apereo.org/projects/uportal
Apache License 2.0
270 stars 273 forks source link

Minor code refactoring changes #2778

Closed HimanshiVerma05 closed 5 months ago

HimanshiVerma05 commented 5 months ago
Checklist
Description of change

This PR includes minor code refactoring changes - Introduce Explaining Variables: To make code more readable I have introduced variables. Decompose Complex Condition: Decomposed complex if condition to make it more readable Use Constructor Injection: Instead of using setter injection for usernameAttributeProvider and personAttributeDao, you can use constructor injection. This ensures that the dependencies are injected when the object is created and makes the class immutable. Extract Method for Query Transformation: The switch statement that modifies the query based on the search method can be extracted into a separate method for better readability and maintainability. Use Diamond Operator: When creating instances of collections, you can use the diamond operator (<>) to reduce redundant type declarations.