search

uPortal-Project / uPortal

Enterprise open source portal built by and for the higher education community.
https://www.apereo.org/projects/uportal
Apache License 2.0
270 stars 273 forks source link

fix/issue-#2800: Fix bug with favorites getting deleted when a favori… #2801

Closed groybal closed 2 months ago

groybal commented 3 months ago

…ted portlet gets deleted and a user subequently favorites another portlet or unfavorites a portlet

Checklist
Description of change

See Issue #2800

Updates have been made such that when a user favorites or unfavorites a portlet, the code will first remove any orphaned favorites (favorites for portlets that have been deleted). What was happening previously was that the UserLayoutManager.saveLayout() method was finding the orphaned favorites and pruning the node "linked-list" at that point, resulting in all favorites coming after in the list to be deleted along with the orphan.

groybal commented 3 months ago

Thanks @groybal! When you have a moment could you look into the failing CI job?

Seems to be working now.