uPortal-Project / uPortal

Enterprise open source portal built by and for the higher education community.
https://www.apereo.org/projects/uportal
Apache License 2.0
272 stars 273 forks source link

enhancement(#2351):Adopt uPortal CSS Variables for Web Components to Simplify Skin Management #2860

Open 555vedant opened 2 weeks ago

555vedant commented 2 weeks ago

currently, web components require individual CSS variiables to be defined separately, which adds complexity when integrating with uPortal skins. To streamline styling and ensure consistency, uPortal CSS variables (like those used for portlets) should be directly exposed and defined. This will allow web components to inherit styles such as header text color, content background color, and more, from the uPortal skin without requiring redundant definitions. The solution involves defining key CSS variables in the :root scope that web components can automatically use, improving maintainability and reducing duplication

555vedant commented 1 week ago

@jonathanmtran sir please tell me is there any improvement or suggestion for this PR because from 10th onwards i have MIDSEM exam of college.

555vedant commented 1 week ago

@jonathanmtran is it fine ?

555vedant commented 1 week ago

@jonathanmtran PR ready to merge ??

jonathanmtran commented 1 week ago

I do not feel that this PR is ready to merge.

555vedant commented 1 week ago

@jonathanmtran i also noticed the same problem with less variables we cant do without less , now whats the solution for this PR ??

jonathanmtran commented 1 week ago

I have already described my guess as to what an implementation could look like.

In order to make meaningful progress on implementing this enhancement and if you have not set up an instance of uPortal: you should set up an instance of uPortal using uPortal-start and work on this.