search

uTensor / utensor_cgen

C++ code generator for uTensor https://utensor-cgen.readthedocs.io/en/latest/
Apache License 2.0
50 stars 40 forks source link

Tf update 2.3.1 #137

Closed victorromeo closed 3 years ago

victorromeo commented 3 years ago

This commit is for TensorFlow 2.3.1 support as default minimum

dboyliao commented 3 years ago

@victorromeo What is the version of your pipenv?

victorromeo commented 3 years ago

pipenv, version 11.9.0

dboyliao commented 3 years ago

That's too old. Please update your pipenv and do the update again.

dboyliao commented 3 years ago

After you update your pipenv, I recommend you to update the lock file by running:

$ pipenv install -d --skip-lock
$ pipenv lock

Don't update tensorflow by pipenv install tensorflow==2.3.1

dboyliao commented 3 years ago

The idea is to keep package dependencies defined in setup.py only and use lock file to take care of the dev environment.

victorromeo commented 3 years ago

Sure. In progress. Will let you know once complete.

dboyliao commented 3 years ago

@victorromeo You're really helping. I know updating the lock file is not easy. pipenv lock normally takes long time to finish for a project like this one.

dboyliao commented 3 years ago

Hey, @victorromeo. I am working on #138 and I accidentally update TF to 2.3.1. So I'm about to close this PR, hope you won't mind.

Also, I find out an issue in your last PR (actually not your issue but google's) and I'd like to share with you. In utensor_cgen, we use ortools for tensor memory allocation optimization planning. However, it's fighting Tensorflow where the program will crash if you switch the import order. As a result, you must import utensor_cgen BEFORE import any tensorflow code. I also make update to tests code in #138 so you don't have to worry about it.

Good job!

victorromeo commented 3 years ago

Understood. Thanks for the update.