search

uTensor / utensor_cgen

C++ code generator for uTensor https://utensor-cgen.readthedocs.io/en/latest/
Apache License 2.0
50 stars 40 forks source link

MaxPool op in list-support-ops #139

Closed victorromeo closed 3 years ago

victorromeo commented 3 years ago

Noticed that the MaxPool operator wasn't listed when using list-support-ops.

dboyliao commented 3 years ago

Oh, it was my mistake. You should change _GenericMaxOperator to _GenericMaxPoolOperator. That should fix it.

dboyliao commented 3 years ago

BTW, these generic operators are defined in _graph_builder.py which is related to building graph in utensor_cgen. The modules are arranged in this way since I'd like to keep graph building api to be generic. That is, the graph built with utensor_cgen should be generic and can be lowered to other target by users.

dboyliao commented 3 years ago

@victorromeo, thanks for reporting the issue and the PR. However, there is better way to fix the issue other than this PR and it's fixed at fa8cdb4882. Closing this PR.