uWaterloo / OpenData

Help and Support for University of Waterloo Open Data Initiative
https://api.uwaterloo.ca
90 stars 12 forks source link

InfoSessions Time Zone #183

Closed kade-robertson closed 3 years ago

kade-robertson commented 7 years ago

Currently, the /resources/infosessions endpoint returns the day, the day of week, the start time and the end time of the info session. However, unlike some other sources, there is no time zone information included. This makes localization and time conversion a bit tricky when considering daylight savings and the like, so having a raw date-time string like what is provided with the GooseWatch endpoint among others would be useful. To avoid breaking backwards compatibility, two new entries called start_time_full and end_time_full (or something along those lines) could be added.

JoeRadman commented 7 years ago

Thanks - I'll look into that and make the changes.

Joe Radman

On Mar 29, 2017, at 10:49 AM, Kade notifications@github.com wrote:

Currently, the /resources/infosessions endpoint returns the day, the day of week, the start time and the end time of the info session. However, unlike some other sources, there is no time zone information included. This makes localization and time conversion a bit tricky when considering daylight savings and the like, so having a raw date-time string like what is provided with the GooseWatch endpoint among others would be useful. To avoid breaking backwards compatibility, two new entries called start_time_full and end_time_full (or something along those lines) could be added.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kade-robertson commented 7 years ago

Great, thanks. Is it also possible to implement this for the /terms/{term}/examschedule endpoint? Specifically, the list containing each section for a class follows the same time format as /resources/infosessions does and likely could have the same solution applied.

axyjo commented 7 years ago

@JoeRadman This would be easily fixed with #156

sbobkin commented 3 years ago

Closing as this is v2 related, and it's no longer available.