ua-parser / uap-go

Go implementation of ua-parser
Other
357 stars 106 forks source link

Unable to recognize iPad OS #81

Closed tanvir-retailai closed 1 year ago

tanvir-retailai commented 1 year ago

@elsigh Following user-agent strings never return "iPad OS" via client.Os.Family:

"Mozilla/5.0 (iPad; CPU OS 13_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/87.0.4280.77 Mobile/15E148 Safari/604.1"

"Mozilla/5.0 (iPad; CPU OS 11_0 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) Version/11.0 Mobile/15A5341f Safari/604.1"

"Mozilla/5.0 (iPad; CPU OS 11_2_5 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) Version/11.0 Mobile/15D60 Safari/604.1"

"Mozilla/5.0 (iPad; CPU OS 11_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/66.0.3359.122 Mobile/15E148 Safari/605.1"

"Mozilla/5.0 (iPad; CPU OS 13_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) FxiOS/15.0 Mobile/15E148 Safari/605.1.15"
dgoldstein0 commented 1 year ago

I defer to uap-core here, who according to the linked issue says iPad OS isn't a thing and it's just iOS.

if there's anything misdetected, please file an issue / fix in uap-core, and we can update our uap-core submodule to get those fixes.