`mypy --strict` - Githubissues

masklinn commented 8 months ago

The "current" mypy configuration (currently being added in #116) is an ad-hoc set of a few optional checks, instead we should use the strict mode and relax the checks we want to ignore, either via the CLI (if globally) or on a per-file basis, specifically:

the legacy code is almost entirely untyped, and maybe we'll improve that in the future but for now it doesn't really matter
strict typing of pytest functions is probably unnecessary, the return types at least should be ignored / implied because it's not worth the hassle

The mypy configuration should also be lifted into a proper configuration file so it can be invoked independently with the right configuration, and doesn't need to be sync'd by hand between tox and gha.

masklinn commented 8 months ago

Now that I'm looking at the thing this issue is kinda dumb, it should be done as part of #116 which also needs to add GHA support, which is currently missing.

masklinn commented 8 months ago

Fixed as part of #116.

Set every option individually as strict doesn't allow per-module overrides, as explained in python/mypy#11401

ua-parser / uap-python

`mypy --strict` #179