search

ua-sista / ua-ros-pkg

Automatically exported from code.google.com/p/ua-ros-pkg
0 stars 1 forks source link

Minimum valid motor ID is 0, not 1 #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I noticed the documentation for dynamixel_controllers says the minimum valid 
motor ID is 1, but it's actually 0 (according to the Dynamixel manuals and my 
own experience). I'm not sure if this is an issue in the code or only in the 
documentation. (Sorry if this is the wrong place to report that.)

Original issue reported on code.google.com by elizabet...@ou.edu on 5 Jan 2012 at 2:51

GoogleCodeExporter commented 9 years ago 
Hi Elizabeth, I haven't extensively tested everything, but after a quick test 
it looks like there are no problems when using id 0 with dynamixel_controllers 
package. Did you have some weird behavior when using id 0?

PS. This is a great place to report issues :)

Original comment by areb...@gmail.com on 5 Jan 2012 at 3:02

GoogleCodeExporter commented 9 years ago 
I haven't used the package much yet, but so far I haven't had any problems with 
ID 0. It might be nice for people in the future if the documentation could be 
changed to reflect ID 0 being valid though.

Original comment by elizabet...@ou.edu on 11 Jan 2012 at 5:03

GoogleCodeExporter commented 9 years ago 
I found one place in the actual code that could cause problems for people using 
ID 0 if they didn't specify 0 as the minimum ID in the config file. Line 84 in 
dynamixel_controllers/nodes/controller_manager.py:
min_motor_id = port_config['min_motor_id'] if 'min_motor_id' in port_config 
else 1

Original comment by elizabet...@ou.edu on 14 Jan 2012 at 7:12

GoogleCodeExporter commented 9 years ago 
Thanks for the report, fixed in revision 1585. I will update the docs with next 
release, right around the time when ROS Fuerte is released.

Original comment by areb...@gmail.com on 17 Jan 2012 at 7:02

GoogleCodeExporter commented 9 years ago

Original comment by areb...@gmail.com on 10 Dec 2012 at 6:06