ua-snap / cmip6-utils

Pipelines and utilites for working with CMIP6 data
1 stars 1 forks source link

Minor enhancement idea for QC script #12

Open kyleredilla opened 8 months ago

kyleredilla commented 8 months ago

I actually had another review idea for this file before it got merged, not critical at all just wanted to jot it down in a ticket. The pathlib is the preferred version of the os.path module, I would drop os module if it is only used for path stuff, since Path is loaded you should be able to actually read the QC csv using Path as a converter function like:

pd.read_csv(qc_file, converters={"data_file": Path, "slurm_file": Path})

Implied here is that the columns have names instead of leaving them unnamed, which would also improve clarity.