search

ua-snap / data-api

SNAP data API
MIT License
4 stars 0 forks source link

Update Mean Annual Temperature mean/min/max table to compute across all models/scenarios #437

Open brucecrevensten opened 5 months ago

brucecrevensten commented 5 months ago

Double check how this is computed. From how it's explained in Arctic EDS it may just be RCP8.5 / 5-mo-avg. We want this to compute across all models and scenarios (do not include 5-mo-avg as a model!).

brucecrevensten commented 3 weeks ago

Create associated ticket in EDS repo to track the GUI changes once this is incorporated upstream.

BobTorgerson commented 2 weeks ago

We had questions regarding this issue that I think only @brucecrevensten will be able to clarify so that we implement this in a desired fashion.

Exploring this ticket led me to identify these sections of code as being what generate the Annual Mean Temperature for the 5-model average at RCP 8.5. https://github.com/ua-snap/data-api/blob/f36524afc5f19002839831929f80c7fa1bfbd04d/routes/taspr.py#L850-L852 https://github.com/ua-snap/data-api/blob/f36524afc5f19002839831929f80c7fa1bfbd04d/routes/taspr.py#L884-L929

The coverage that this is pulling the data from contains only 3 model choices: 5-model average (already computed), GFDL-CM3, and NCAR-CCSM4 along with RCPs 4.5, 6.0, and 8.5. What we currently do is simply take the monthly mean values to compute an annual mean temperature and for the eras, we compute the minimum of the annual means, average of the annual means, and the maximum of the annual means.

The only thing I can think of that matches the title and description of this issue is that we should replace the 5-model average at RCP 8.5 with the two other models and do the annual means across all of their scenarios to find their annual mean MMMs. Before we move forward with this issue, we will need clarity on what is desired as an outcome.